Skip to content

Add clarification about missing reply_to handling in comment creation #11838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShagunGupta56 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clarification about missing reply_to handling in comment creation #11838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/helpers/comment_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ module CommentHelper
class CommentError < ArgumentError
end

# NOTE:
# reply_to parameter is handled in CommentsController,
# but it is not passed to add_comment here.
# This may cause replies to be posted as independent comments.

def create_comment(node, user, body)
@comment = node.add_comment(uid: user.uid, body: body)
if user && @comment.save
Expand Down
Loading