-
Notifications
You must be signed in to change notification settings - Fork 6
Branch for coadd + bugfixes + bump python versions #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/testing.yml
Outdated
| os: [ubuntu-latest] | ||
| tox_env: [py37, py38, py39, py310] | ||
| include: | ||
| - tox_env: py39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 3.9 is already EOL, you can probably go up to 3.14 now.
pyproject.toml
Outdated
| [tool.black] | ||
| line-length = 79 | ||
| target-version = ["py38"] | ||
| target-version = ["py39", "py310", "py311", "py312"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, 3.9 is end of life, and you can add 3.13 & 3.14
pyproject.toml
Outdated
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop 3.9
setup.py
Outdated
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you even need a setup.py? seems redundant if you already have a pyproject.toml, but in any case, you can drop 3.9 here too.
|
it's merge ready for me |
This PR addresses several issues: