[ci] Port anyscale image builds to Wanda pipeline#59937
[ci] Port anyscale image builds to Wanda pipeline#59937andrew-anyscale wants to merge 1 commit intoandrew/revup/master/push-anyscale-wandafrom
Conversation
|
f104bf5 to
288cadb
Compare
f963b42 to
0710971
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors the Anyscale image build process to use Wanda for building and a new Python script for pushing images to multiple registries. The changes include new Wanda configuration files, the push_anyscale_image.py script, and updates to the Buildkite pipeline. My review identifies a few critical issues that will break the build, including a missing file in a Bazel target and an incomplete matrix configuration in the pipeline. I've also provided several suggestions to improve maintainability by reducing code duplication and making parts of the new script less brittle.
0710971 to
4cdb2dd
Compare
46cc862 to
70df756
Compare
4cdb2dd to
f65669a
Compare
70df756 to
ae32d45
Compare
f65669a to
1141897
Compare
ae32d45 to
04cfd26
Compare
af3b600 to
6bbeb9e
Compare
04cfd26 to
55d1473
Compare
6bbeb9e to
1f049e8
Compare
55d1473 to
84d7479
Compare
84d7479 to
c275fe2
Compare
d43ccd7 to
8980d9c
Compare
7c78fa2 to
29cf5ab
Compare
8980d9c to
4a143b7
Compare
29cf5ab to
d566c8a
Compare
4a143b7 to
9243672
Compare
d566c8a to
9190029
Compare
0ec84ea to
ea2ca72
Compare
c61e365 to
436f981
Compare
436f981 to
c3f92d3
Compare
958fd5d to
338037a
Compare
c3f92d3 to
c6d75f5
Compare
338037a to
4129c6e
Compare
| if rayci_build_id: | ||
| tags.extend(f"{rayci_build_id}{py_tag}{ptag}" for ptag in platform_tags) | ||
|
|
||
| return tags |
There was a problem hiding this comment.
Missing empty platform alias for ray-ml images
High Severity
The _get_image_tags() function doesn't accept image_type as a parameter and therefore cannot generate the empty platform alias tag for ray-ml images. The original docker_container.py code adds an empty platform tag ("") for ray-ml images when using GPU_PLATFORM, producing tags like 123456-py310 (without platform suffix). The new implementation only generates -cu121 and -gpu tags, missing this alias that release tests depend on.
|
|
||
| # GPU_PLATFORM is the default GPU platform that gets aliased as "-gpu" | ||
| # This must match the definition in ci/ray_ci/docker_container.py | ||
| GPU_PLATFORM = "cu12.1.1-cudnn8" |
There was a problem hiding this comment.
Duplicated GPU_PLATFORM constant should be imported
Medium Severity
GPU_PLATFORM = "cu12.1.1-cudnn8" is duplicated here, but this constant already exists in ci/ray_ci/docker_container.py and is already imported by the sibling file push_ray_image.py. This should be imported from docker_container rather than redefined.
c6d75f5 to
bc74e0d
Compare
4129c6e to
356559a
Compare
bc74e0d to
fcda219
Compare
356559a to
ef0f4bb
Compare
| # For GPU_PLATFORM, also create -gpu alias (release tests use type: gpu) | ||
| platform_tags = [platform_tag] | ||
| if platform == GPU_PLATFORM: | ||
| platform_tags.append("-gpu") |
There was a problem hiding this comment.
Missing empty platform alias tags for ray-ml images
High Severity
The _get_image_tags function is missing the empty platform alias logic that exists in the original AnyscaleDockerContainer and docker_tags_lib.py. For ray-ml images with GPU_PLATFORM, the old code generates three platform tags: -cu121, -gpu, and an empty suffix (just version-pyXX). The new code only generates -cu121 and -gpu. The test in test_anyscale_docker_container.py expects tags like 123456-py310 (no platform suffix) for ray-ml images, which will be missing with the new implementation.
|
Moving to draft while I perform a refactor to reduce on overlap with EDIT: done. |
c67c571 to
0ec46b1
Compare
Replace Docker-based anyscale image builds with Wanda-based approach. Images are now built using Wanda configs and published using crane via push_anyscale_image script. Pipeline changes: - Add Wanda build steps for ray-anyscale (cpu/cuda), ray-llm-anyscale, and ray-ml-anyscale images - Add wheel build dependencies (ray-core, ray-dashboard, ray-java, ray-wheel) - Update publish steps to use push_anyscale_image with GCP/Azure auth Topic: anyscale-image Relative: push-anyscale-wanda Signed-off-by: andrew <andrew@anyscale.com>
0ec46b1 to
73ffe55
Compare


Replace Docker-based anyscale image builds with Wanda-based approach.
Images are now built using Wanda configs and published using crane via push_anyscale_image script.
Pipeline changes:
Topic: anyscale-image
Relative: push-anyscale-wanda
Signed-off-by: andrew andrew@anyscale.com