[ci] refactor push_ray_image shared functions to image_tags_lib #60793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Topic: image-tags-lib Signed-off-by: andrew <andrew@anyscale.com>
Contributor
Author
Contributor
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors shared image tagging and crane utility functions into a new image_tags_lib.py module. This significantly improves code organization and reusability, as demonstrated by push_ray_image.py now leveraging these new utilities. The changes include updating Bazel build files, creating the new library with comprehensive unit tests, and modifying the existing push_ray_image.py to use the refactored functions. The approach taken is sound, and the new tests provide good coverage for the extracted logic.
aslonnie
approved these changes
Feb 6, 2026
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…project#60793) There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…project#60793) There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…project#60793) There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Signed-off-by: andrew <andrew@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work. Signed-off-by: andrew <andrew@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is significant overlap with the next feature of push_anyscale_image, so this refactor reduces on a lot of duplicated work.
Topic: image-tags-lib
Signed-off-by: andrew andrew@anyscale.com