add new changes to work with in cursor editor #19
Conversation
rhalaly
left a comment
rhalaly
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
I saw that you added the commandPalette and mostly reorder stuff and remove stuff. Some of them are crucial for the extension to run properly.
Please try to reduce the diffs as much as possible and add only the crucial fields for Cursor editor.
BTW, I saw that the extension is properly supported by other VS Code distributions, what is the unique requirement for it?
| "activationEvents": [ | ||
| "onStartupFinished", | ||
| "onView:fileExplorer", | ||
| "onCommand:scope-to-this.scope", |
There was a problem hiding this comment.
These are needed in some cases where you run the commands before VS Code is loaded or file explorer is opened. Please revert
| { | ||
| "command": "scope-to-this.clear", | ||
| "group": "navigation", | ||
| "when": "view == 'workbench.explorer.fileView' && scopeToThis.scoped" |
There was a problem hiding this comment.
I highly encourage to reduce unnecessary diffs. Since this is just a reorder, please revert
| "group": "navigation" | ||
| } | ||
| ], | ||
| "explorer/context": [ |
There was a problem hiding this comment.
Same comment regarding reordring, please keep that in the same place
| { | ||
| "command": "scope-to-this.scope", | ||
| "group": "2_workspace@1", | ||
| "when": "activeViewlet == 'workbench.view.explorer' && explorerResourceIsFolder" |
There was a problem hiding this comment.
This is mandatory, why removing it? Please revert
| "explorer/context": [ | ||
| { | ||
| "command": "scope-to-this.scope", | ||
| "group": "navigation" |
|
Hi @ekinertac , please make changes as suggested cause i would love to use this extension on cursor. |
|
up!! |
4 participants
Love the extension but it doesn't worked as expected in Cursor editor. add some package.json definitions to work without issues.