Skip to content

add new changes to work with in cursor editor #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekinertac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add new changes to work with in cursor editor #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
},
"activationEvents": [
"onStartupFinished",
"onView:fileExplorer",
"onCommand:scope-to-this.scope",
Copy link
Owner

@rhalaly rhalaly Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are needed in some cases where you run the commands before VS Code is loaded or file explorer is opened. Please revert

"onCommand:scope-to-this.clear"
"onView:fileExplorer"
],
"contributes": {
"commands": [
Expand All @@ -52,18 +50,23 @@
}
],
"menus": {
"explorer/context": [
{
"command": "scope-to-this.scope",
"group": "navigation"
Copy link
Owner

@rhalaly rhalaly Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the group?

}
],
"view/title": [
{
"command": "scope-to-this.clear",
"group": "navigation",
"when": "view == 'workbench.explorer.fileView' && scopeToThis.scoped"
Copy link
Owner

@rhalaly rhalaly Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly encourage to reduce unnecessary diffs. Since this is just a reorder, please revert

"when": "view == workbench.explorer.fileView && scopeToThis.scoped",
"group": "navigation"
}
],
"explorer/context": [
Copy link
Owner

@rhalaly rhalaly Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding reordring, please keep that in the same place

"commandPalette": [
{
"command": "scope-to-this.scope",
"group": "2_workspace@1",
"when": "activeViewlet == 'workbench.view.explorer' && explorerResourceIsFolder"
Copy link
Owner

@rhalaly rhalaly Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mandatory, why removing it? Please revert

"command": "scope-to-this.clear",
"when": "scopeToThis.scoped"
}
]
}
Expand Down