Added volume control parameter at audio_capture/play#258
Open
BeomsuHa wants to merge 4 commits intoros-drivers:masterfrom
Open
Added volume control parameter at audio_capture/play#258BeomsuHa wants to merge 4 commits intoros-drivers:masterfrom
BeomsuHa wants to merge 4 commits intoros-drivers:masterfrom
Conversation
Add volume parameter
Add volume parameter
Member
|
Thank you for your contribution! Could you provide some video to show this feature if possible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sound play, there is a volume arg which can control the output volume
but in audio_capture and audio_play, there are no option to control the volume
So I added the volume parameter at audio_capture/audio_play as ~capture_volume/~play_volume