Skip to content

Comments

Add missing Vercel KV deps & update codeowners#271

Merged
kzuraw merged 3 commits intomainfrom
fix-missing-vercel-kv
Feb 5, 2025
Merged

Add missing Vercel KV deps & update codeowners#271
kzuraw merged 3 commits intomainfrom
fix-missing-vercel-kv

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Feb 5, 2025

Fixes error on API routes:

CleanShot 2025-02-05 at 10 14 37@2x

@kzuraw kzuraw changed the title Add missing Vercel KV deps Add missing Vercel KV deps & update codeowners Feb 5, 2025
@kzuraw kzuraw requested a review from lkostrowski February 5, 2025 09:17
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Differences Found

⚠️ 3 packages or licenses were added.

Expand
License	Package
Apache-2.0	@vercel/kv
MIT	@upstash/redis
MIT	crypto-js

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
MPL-2.0 1
Packages
  • axe-core
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
CC0-1.0 2
Packages
  • language-subtag-registry
  • type-fest
<<missing>> 3
Packages
  • busboy
  • saleor-app-template
  • streamsearch
BSD-3-Clause 12
Packages
  • @humanwhocodes/object-schema
  • @saleor/eslint-plugin-saleor-app
  • abab
  • asn1js
  • esquery
  • ieee754
  • immutable
  • signedsource
  • source-map
  • source-map-js
  • sprintf-js
  • tough-cookie
BSD-2-Clause 15
Packages
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • css-what
  • damerau-levenshtein
  • dotenv
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • uri-js
  • webidl-conversions
Apache-2.0 22
Packages
  • @ampproject/remapping
  • @humanwhocodes/config-array
  • @humanwhocodes/module-importer
  • @opentelemetry/api
  • @opentelemetry/semantic-conventions
  • @swc/helpers
  • @vercel/kv
  • aria-query
  • axobject-query
  • bser
  • detect-libc
  • doctrine
  • eslint-visitor-keys
  • fb-watchman
  • human-signals
  • json-to-pretty-yaml
  • remedial
  • retes
  • rxjs
  • typescript
  • And 2 more...
ISC 38
Packages
  • @saleor/app-sdk
  • ast-types-flow
  • cli-width
  • cliui
  • electron-to-chromium
  • eslint-import-resolver-typescript
  • fastq
  • flatted
  • fs.realpath
  • get-caller-file
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • isexe
  • lru-cache
  • minimatch
  • mute-stream
  • once
  • And 18 more...
MIT 744
Packages
  • @0no-co/graphql.web
  • @aashutoshrathi/word-wrap
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-environment-visitor
  • @babel/helper-function-name
  • @babel/helper-hoist-variables
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • And 724 more...

package.json Outdated
"@saleor/app-sdk": "0.51.0",
"@saleor/macaw-ui": "1.1.10",
"@urql/exchange-auth": "^1.0.0",
"@vercel/kv": "^3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, vercel kv should not be required to run, unless you chose to use kv in APL.

Does it work if you use eg FileAPL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out Vercel KV so it won't be included by default

@kzuraw kzuraw requested a review from lkostrowski February 5, 2025 09:47
@kzuraw kzuraw merged commit 617fdfe into main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants