Skip to content

Add missing Vercel KV deps & update codeowners #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzuraw merged 3 commits into from
Feb 5, 2025
Merged

Add missing Vercel KV deps & update codeowners #271

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2477300
Add missing Vercel KV deps
kzuraw Feb 5, 2025
011c533
update codeowners
kzuraw Feb 5, 2025
e79f926
dont include vercel kv by default
kzuraw Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
* @saleor/apps-guild
/.github/ @saleor/SRE
* @saleor/extensibility-team-js
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"@saleor/app-sdk": "0.51.0",
"@saleor/macaw-ui": "1.1.10",
"@urql/exchange-auth": "^1.0.0",
"@vercel/kv": "^3.0.0",
Copy link
Member

@lkostrowski lkostrowski Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, vercel kv should not be required to run, unless you chose to use kv in APL.

Does it work if you use eg FileAPL?

Copy link
Contributor Author

@kzuraw kzuraw Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out Vercel KV so it won't be included by default

"@vitejs/plugin-react": "4.2.1",
"graphql": "^16.8.1",
"graphql-tag": "^2.12.6",
Expand Down
29 changes: 27 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.