Retry clicking on dropdown and wait for first item #5398
Merged
Conversation
🦋 Changeset detectedLatest commit: 6092edc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Summary
Failed TestsNo failed tests ✨ Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
szczecha
changed the title
poulch
reviewed
Feb 10, 2025
michalina-graczyk
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5398 +/- ##
========================================
Coverage 61.92% 61.92%
========================================
Files 1245 1245
Lines 21530 21530
Branches 4260 4501 +241
========================================
Hits 13333 13333
+ Misses 8160 7652 -508
- Partials 37 545 +508 ☔ View full report in Codecov by Sentry. |
Contributor
merge-reports: Run #4438
❌ Some tests failed!
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
andrzejewsky
approved these changes
Feb 17, 2025
Contributor
merge-reports: Run #4439
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
witoszekdev
pushed a commit
that referenced
this pull request
Feb 18, 2025
* add wait for first item * do not overwrite comment with results * use expect.toPass block * restore overwrite comment to true * remove waitForDOMToFullyLoad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the change
fix flaky SALEOR_198
I use https://playwright.dev/docs/test-assertions#expecttopass to make sure that clicking at dropdown shows list of options