-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Retry clicking on dropdown and wait for first item #5398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
32e661a
add wait for first item
szczecha 3634fb7
do not overwrite comment with results
szczecha 56c8b5a
use expect.toPass block
szczecha cb2043b
restore overwrite comment to true
szczecha 5260544
remove waitForDOMToFullyLoad
szczecha f9c3b28
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha 01e7c44
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha f374420
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha 3d92daa
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha cd46394
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha ab6a503
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha b4064d1
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha 6092edc
Merge branch 'main' into qa-290-flaky-saleor-198
szczecha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| Modify menu tests to ensure the first item in the list is visible before proceeding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.