Conversation
🦋 Changeset detectedLatest commit: b76edb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
Updates Editor.js dependencies to fix list editing issues and inline toolbar truncation problems in description fields. The changes migrate custom icons to match the new Editor.js icon format and remove positioning styles that were causing toolbar display issues.
- Updated Editor.js and related plugin dependencies to newer versions
- Migrated strikethrough icon to match new Editor.js icon format
- Fixed inline toolbar positioning and overflow issues
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Editor.js and plugin dependencies to newer versions |
| src/icons/StrikethroughIcon.tsx | Replaces custom strikethrough icon with Editor.js compatible version |
| src/components/RichTextEditor/consts.ts | Updates import to use new strikethrough icon export |
| src/components/RichTextEditor/styles.ts | Removes problematic positioning styles and adds overflow fix |
| .changeset/two-glasses-doubt.md | Adds changelog entry for the dependency updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.21 #5911 +/- ##
==========================================
+ Coverage 65.16% 65.17% +0.01%
==========================================
Files 1445 1446 +1
Lines 25046 25065 +19
Branches 4926 4933 +7
==========================================
+ Hits 16322 16337 +15
- Misses 8680 8684 +4
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Differences FoundExpandLicense Package MIT @codexteam/icons MIT @editorjs/dom MIT @editorjs/helpers SummaryExpand
|
kzuraw
requested review from
Copilot,
lkostrowski and
witoszekdev
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
unfortunately not - it will be different than the rest of the icons 😞
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| Fixed issues with ordered and unordered lists in product and category descriptions. Lists now work correctly when editing, and the inline formatting toolbar no longer gets cut off on smaller screens. |
There was a problem hiding this comment.
question: should we also add a note about the format change in editor.js?
There was a problem hiding this comment.
I'm wondering about it - format is changed but we are converting to old one anyway and end users won't be able to see the difference
Scope of the change
This PR fixes issues with ordered and unordered lists in rich text descriptions and adds backward compatibility handling for EditorJS list format changes.
Problem
After upgrading to @editorjs/list v2.0.0+, the list format changed from simple string arrays to objects with content and metadata. This created compatibility issues with storefronts expecting the legacy format, potentially breaking existing list rendering.
Changes
🐛 Bug Fixes
🔧 Technical Implementation
1. List Format Conversion (
convertEditorJSListBlocks)Created a utility function to convert between EditorJS list formats:
New Format (v2.0.0+):
{ "items": [ { "content": "Item 1", "meta": {} }, { "content": "Item 2", "meta": {} } ] }Legacy Format (pre-v2.0.0):
{ "items": ["Item 1", "Item 2"] }Location:
src/components/RichTextEditor/utils.ts:372. Integration Points
The conversion is applied at two critical points:
src/components/RichTextEditor/RichTextEditor.tsx:109)src/utils/richText/useRichText.ts:37)3. Dependencies Updated
@editorjs/editorjs:^2.30.2→^2.30.6@editorjs/checklist:^1.6.0→^1.7.0@editorjs/header:^2.8.7→^2.8.8@editorjs/list:^1.10.0→^2.0.1(major version with format changes)@editorjs/quote:^2.7.2→^2.7.44. UI/UX Improvements
📝 Documentation
convertEditorJSListBlocks✅ Testing
Added comprehensive unit test suite covering:
Test file:
src/components/RichTextEditor/utils.test.tsImpact
User-Facing
Developer-Facing
Testing Instructions
Test list creation:
Test legacy content:
Test toolbar: