[3.21] Upgrade macaw-ui-next and fix EditorJS list conversion#5927
[3.21] Upgrade macaw-ui-next and fix EditorJS list conversion#5927
Conversation
- Upgrade @saleor/macaw-ui-next from 1.1.19 to 1.3.5 - Add lucide-react dependency (required by macaw-ui-next) - Move convertEditorJSListBlocks call to save() method in ReactEditorJS - Simplify RichTextEditor and useRichText by removing redundant list conversion - Implement dangerouslyLowLevelInstance in ClientEditorCore (EditorCore interface requirement) This ensures list block conversion happens once at the save level rather than multiple times in consuming components. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the macaw-ui-next library from version 1.1.19 to 1.3.5 and refactors EditorJS list conversion logic to fix issues with ordered and unordered lists in product/category descriptions.
- Moved list block conversion from multiple locations to a centralized save() method in ReactEditorJS
- Added required interface implementation for dangerouslyLowLevelInstance in ClientEditorCore
- Added @ts-expect-error comment to handle type issue with upgraded macaw-ui-next icon color prop
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Upgraded @saleor/macaw-ui-next from 1.1.19 to 1.3.5 |
| ReactEditorJS.tsx | Centralized list conversion in save() method and implemented dangerouslyLowLevelInstance |
| RichTextEditor.tsx | Removed redundant list conversion call from onChange handler |
| useRichText.ts | Removed redundant list conversion call from save function |
| FilterPresetItem.tsx | Added @ts-expect-error comment for icon color prop type issue |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.21 #5927 +/- ##
==========================================
- Coverage 65.17% 65.17% -0.01%
==========================================
Files 1446 1446
Lines 25065 25065
Branches 5112 5112
==========================================
- Hits 16337 16335 -2
- Misses 8684 8686 +2
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Differences FoundExpandLicense Package ISC lucide-react SummaryExpand
|
Explains why this property is required by EditorCore interface and why it returns null (encapsulation and preventing unsafe access). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Changes
This ensures list block conversion happens once at the save level rather than multiple times in consuming components, fixing issues with lists in descriptions.
Test plan
🤖 Generated with Claude Code