Skip to content

Fix release 3.22#5962

Merged
kzuraw merged 1 commit into3.22from
fix-release-3.22
Oct 10, 2025
Merged

Fix release 3.22#5962
kzuraw merged 1 commit into3.22from
fix-release-3.22

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 10, 2025

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 10, 2025 09:43
@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: 9eb3b27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Oct 10, 2025 9:43am

@kzuraw kzuraw marked this pull request as ready for review October 10, 2025 09:44
@kzuraw kzuraw requested a review from a team as a code owner October 10, 2025 09:44
@kzuraw kzuraw merged commit 62c8d59 into 3.22 Oct 10, 2025
22 of 27 checks passed
@kzuraw kzuraw deleted the fix-release-3.22 branch October 10, 2025 09:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the release process by replacing the changeset-based release command with a direct git tagging approach and documents the change for version 3.22.

  • Replaces changeset tag with direct git tagging using the package version
  • Adds a changeset entry documenting the workflow retrigger and changeset tag removal

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Updates release script to use git tag directly instead of changeset tag
.changeset/open-drinks-juggle.md Documents the change with a patch-level changeset entry

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"prepare": "is-ci || husky install",
"preview": "vite preview",
"release": "changeset tag && git push --follow-tags",
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release script uses shell variable substitution that may not work consistently across different environments. Consider using a more robust approach like npm version or a Node.js script to ensure cross-platform compatibility.

Suggested change
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
"release": "npm version $npm_package_version --git-tag-version && git push --follow-tags",

Copilot uses AI. Check for mistakes.
"prepare": "is-ci || husky install",
"preview": "vite preview",
"release": "changeset tag && git push --follow-tags",
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new release script doesn't validate if the tag already exists before creating it, which could cause the command to fail. Consider adding a check or using git tag -f if overwriting is intended.

Suggested change
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
"release": "TAG=$npm_package_version; (git tag | grep -q \"^$TAG$\") || git tag \"$TAG\"; git push --follow-tags",

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC-BY-3.0 1
Packages
  • spdx-exceptions
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • utf8-byte-length
<<missing>> 2
Packages
  • busboy
  • streamsearch
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
CC0-1.0 2
Packages
  • spdx-license-ids
  • type-fest
SEE LICENSE IN LICENSE 2
Packages
  • posthog-js
  • spawndamnit
BlueOak-1.0.0 3
Packages
  • jackspeak
  • package-json-from-dist
  • path-scurry
BSD-2-Clause 24
Packages
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • normalize-package-data
  • nth-check
  • regjsparser
  • stringify-object
  • And 4 more...
BSD-3-Clause 43
Packages
  • @saleor/app-sdk
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-arm64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • @sinonjs/fake-timers
  • abab
  • asn1js
  • babel-plugin-istanbul
  • chroma-js
  • dataloader
  • diff
  • esquery
  • exenv
  • And 23 more...
ISC 50
Packages
  • @isaacs/cliui
  • @istanbuljs/load-nyc-config
  • anymatch
  • boolbase
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • foreground-child
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • hosted-git-info
  • inflight
  • inherits
  • ini
  • And 30 more...
Apache-2.0 57
Packages
  • @ampproject/remapping
  • @editorjs/editorjs
  • @eslint/config-array
  • @eslint/config-helpers
  • @eslint/core
  • @eslint/object-schema
  • @eslint/plugin-kit
  • @humanfs/core
  • @humanfs/node
  • @humanwhocodes/module-importer
  • @humanwhocodes/retry
  • @opentelemetry/api
  • @opentelemetry/semantic-conventions
  • @playwright/test
  • @pollyjs/adapter
  • @pollyjs/core
  • @pollyjs/persister
  • @pollyjs/utils
  • @swc/core
  • @swc/core-darwin-arm64
  • And 37 more...
MIT 1262
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-globals
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1242 more...

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.08%. Comparing base (dce7d7c) to head (9eb3b27).
⚠️ Report is 2 commits behind head on 3.22.

Additional details and impacted files
@@           Coverage Diff            @@
##             3.22    #5962    +/-   ##
========================================
  Coverage   40.08%   40.08%            
========================================
  Files        2474     2474            
  Lines       40256    40256            
  Branches     9187     8856   -331     
========================================
  Hits        16138    16138            
  Misses      24091    24091            
  Partials       27       27            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lkostrowski added a commit that referenced this pull request Oct 14, 2025
* Fix release 3.22 (#5962)

* Release 3.22 (#5963)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* revert changes to worfklows (#5964)

---------

Co-authored-by: Krzysztof Żuraw <9116238+krzysztofzuraw@users.noreply.github.com>
Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants