Conversation
🦋 Changeset detectedLatest commit: 9eb3b27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release process by replacing the changeset-based release command with a direct git tagging approach and documents the change for version 3.22.
- Replaces
changeset tagwith direct git tagging using the package version - Adds a changeset entry documenting the workflow retrigger and changeset tag removal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates release script to use git tag directly instead of changeset tag |
| .changeset/open-drinks-juggle.md | Documents the change with a patch-level changeset entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "prepare": "is-ci || husky install", | ||
| "preview": "vite preview", | ||
| "release": "changeset tag && git push --follow-tags", | ||
| "release": "echo $npm_package_version | xargs git tag && git push --follow-tags", |
There was a problem hiding this comment.
The release script uses shell variable substitution that may not work consistently across different environments. Consider using a more robust approach like npm version or a Node.js script to ensure cross-platform compatibility.
| "release": "echo $npm_package_version | xargs git tag && git push --follow-tags", | |
| "release": "npm version $npm_package_version --git-tag-version && git push --follow-tags", |
| "prepare": "is-ci || husky install", | ||
| "preview": "vite preview", | ||
| "release": "changeset tag && git push --follow-tags", | ||
| "release": "echo $npm_package_version | xargs git tag && git push --follow-tags", |
There was a problem hiding this comment.
The new release script doesn't validate if the tag already exists before creating it, which could cause the command to fail. Consider adding a check or using git tag -f if overwriting is intended.
| "release": "echo $npm_package_version | xargs git tag && git push --follow-tags", | |
| "release": "TAG=$npm_package_version; (git tag | grep -q \"^$TAG$\") || git tag \"$TAG\"; git push --follow-tags", |
Differences Found✅ No packages or licenses were added. SummaryExpand
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.22 #5962 +/- ##
========================================
Coverage 40.08% 40.08%
========================================
Files 2474 2474
Lines 40256 40256
Branches 9187 8856 -331
========================================
Hits 16138 16138
Misses 24091 24091
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Fix release 3.22 (#5962) * Release 3.22 (#5963) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * revert changes to worfklows (#5964) --------- Co-authored-by: Krzysztof Żuraw <9116238+krzysztofzuraw@users.noreply.github.com> Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Scope of the change