Skip to content

Fix release 3.22 #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzuraw merged 1 commit into from
Oct 10, 2025
Merged

Fix release 3.22 #5962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/open-drinks-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Retrigger workflow & remove changeset tag
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"lint:prettier:check": "prettier --ignore-unknown --check .",
"prepare": "is-ci || husky install",
"preview": "vite preview",
"release": "changeset tag && git push --follow-tags",
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release script uses shell variable substitution that may not work consistently across different environments. Consider using a more robust approach like npm version or a Node.js script to ensure cross-platform compatibility.

Suggested change
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
"release": "npm version $npm_package_version --git-tag-version && git push --follow-tags",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new release script doesn't validate if the tag already exists before creating it, which could cause the command to fail. Consider adding a check or using git tag -f if overwriting is intended.

Suggested change
"release": "echo $npm_package_version | xargs git tag && git push --follow-tags",
"release": "TAG=$npm_package_version; (git tag | grep -q \"^$TAG$\") || git tag \"$TAG\"; git push --follow-tags",

Copilot uses AI. Check for mistakes.
"release:cleanup": "./scripts/release-cleanup.sh",
"serve:lhci": "cross-env NODE_ENV=production npm run server",
"prestart": "npm run generate",
Expand Down
Loading