Skip to content

Comments

App Problems implementation #6283

Merged
lkostrowski merged 57 commits intomainfrom
app-problems
Feb 24, 2026
Merged

App Problems implementation #6283
lkostrowski merged 57 commits intomainfrom
app-problems

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Jan 27, 2026

Copilot AI review requested due to automatic review settings January 27, 2026 18:33
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: c8e3102

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements an "App Problems" feature that displays issues and problems associated with installed apps in the Saleor dashboard.

Changes:

  • Added GraphQL types and fields for app problems (AppProblem, AppProblemCircuitBreaker, AppProblemCustom)
  • Created UI components to display problems in a grouped, collapsible format with badges
  • Integrated problem display into the installed extensions list with problem counts in header
  • Extended webhook delivery errors to be treated as app problems for unified display

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/graphql/types.generated.ts Auto-generated GraphQL type definitions for app problems and new input types
src/graphql/typePolicies.generated.ts Auto-generated Apollo cache policies for new types
src/graphql/hooks.generated.ts Updated fragment to include problems field
src/graphql/fragmentTypes.generated.ts Updated fragment types to include app problem union types
src/fragments/apps.ts Added problems field to InstalledAppDetails fragment
src/extensions/views/InstalledExtensions/hooks/useInstalledExtensions.tsx Modified to fetch and aggregate problems, including webhook errors
src/extensions/views/InstalledExtensions/components/InstalledExtensionsList/InstalledExtensionsList.tsx Refactored to display expandable problems rows
src/extensions/views/InstalledExtensions/components/AppProblems/* New components for displaying problems (list, badges, cards, type badges)
src/extensions/views/InstalledExtensions/InstalledExtensions.tsx Added problems count badge to header
src/extensions/types.ts Added AppProblem types and WebhookDeliveryProblem interface
src/extensions/messages.ts Added problem-related messages for i18n
src/extensions/components/AppAlerts/useAppsAlert.ts Modified to check for app problems and show alerts
src/extensions/components/AppAlerts/SidebarAppAlert.test.tsx Updated test to mock new query
locale/defaultMessages.json Added new message IDs for problems feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 30, 2026 10:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 52.69461% with 158 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.71%. Comparing base (7ea2858) to head (c8e3102).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/AppProblems/ProblemsList/ProblemsList.tsx 20.00% 43 Missing and 1 partial ⚠️
...components/AppProblems/ProblemCard/ProblemCard.tsx 39.39% 18 Missing and 2 partials ⚠️
...ponents/AppProblems/ProblemCard/DismissedLabel.tsx 35.29% 9 Missing and 2 partials ⚠️
...onents/AppProblems/ProblemsBadge/ProblemsBadge.tsx 31.25% 10 Missing and 1 partial ⚠️
.../views/InstalledExtensions/InstalledExtensions.tsx 50.00% 10 Missing ⚠️
...alledExtensions/components/AppProblems/fixtures.ts 0.00% 10 Missing ⚠️
...s/AppProblems/ProblemCard/TimestampWithTooltip.tsx 47.05% 9 Missing ⚠️
.../AppProblems/ProblemsList/ProblemsList.stories.tsx 0.00% 9 Missing ⚠️
...ppProblems/ProblemsBadge/ProblemsBadge.stories.tsx 0.00% 7 Missing ⚠️
...ts/AppProblems/ProblemCard/ProblemCard.stories.tsx 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6283      +/-   ##
==========================================
+ Coverage   42.67%   42.71%   +0.04%     
==========================================
  Files        2517     2534      +17     
  Lines       43696    44006     +310     
  Branches     9954    10434     +480     
==========================================
+ Hits        18647    18799     +152     
+ Misses      25011    23868    -1143     
- Partials       38     1339    +1301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 57 out of 59 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC0-1.0 1
Packages
  • type-fest
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • utf8-byte-length
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
SEE LICENSE IN LICENSE 2
Packages
  • posthog-js
  • spawndamnit
BlueOak-1.0.0 7
Packages
  • @isaacs/cliui
  • glob
  • jackspeak
  • lru-cache
  • minimatch
  • package-json-from-dist
  • path-scurry
<<missing>> 11
Packages
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-arm64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • busboy
  • streamsearch
BSD-2-Clause 23
Packages
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • nth-check
  • regjsparser
  • stringify-object
  • terser
  • And 3 more...
ISC 48
Packages
  • @istanbuljs/load-nyc-config
  • anymatch
  • boolbase
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • foreground-child
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • ini
  • isexe
  • knip
  • And 28 more...
BSD-3-Clause 54
Packages
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/app-sdk
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • And 34 more...
Apache-2.0 64
Packages
  • @editorjs/editorjs
  • @eslint/config-array
  • @eslint/config-helpers
  • @eslint/core
  • @eslint/object-schema
  • @eslint/plugin-kit
  • @humanfs/core
  • @humanfs/node
  • @humanwhocodes/module-importer
  • @humanwhocodes/retry
  • @opentelemetry/api
  • @opentelemetry/api-logs
  • @opentelemetry/core
  • @opentelemetry/exporter-logs-otlp-http
  • @opentelemetry/otlp-exporter-base
  • @opentelemetry/otlp-transformer
  • @opentelemetry/resources
  • @opentelemetry/sdk-logs
  • @opentelemetry/sdk-metrics
  • @opentelemetry/sdk-trace-base
  • And 44 more...
MIT 1304
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-globals
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1284 more...

witoszekdev
witoszekdev previously approved these changes Feb 23, 2026
witoszekdev
witoszekdev previously approved these changes Feb 24, 2026
Copilot AI review requested due to automatic review settings February 24, 2026 10:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 57 out of 59 changed files in this pull request and generated 2 comments.

Added app problems display to the installed extensions list. Each app now shows reported problems with severity badges, timestamps, and dismissal support. The "Open the app" action link is only shown for third-party apps. Requires Saleor 3.22+.

:::warning
This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36). Used with older version, Extensions page will break
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset warning states this release requires Saleor core 3.22.36, which is a very specific version. Consider whether this should be a minimum version requirement (>=3.22.36) rather than requiring an exact version, unless there's a specific reason for the exact version requirement. This could unnecessarily prevent users from upgrading to newer patch versions of Saleor.

Suggested change
This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36). Used with older version, Extensions page will break
This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36) or newer in the 3.22 series. Used with older versions, the Extensions page will break.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 24, 2026 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 95 out of 97 changed files in this pull request and generated 2 comments.

@lkostrowski lkostrowski enabled auto-merge (squash) February 24, 2026 10:41
@lkostrowski lkostrowski merged commit fca0cbf into main Feb 24, 2026
22 of 23 checks passed
@lkostrowski lkostrowski deleted the app-problems branch February 24, 2026 10:46
This was referenced Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test deployment Deploy Pull Request to *.saleor.rocks environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants