Conversation
🦋 Changeset detectedLatest commit: c8e3102 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR implements an "App Problems" feature that displays issues and problems associated with installed apps in the Saleor dashboard.
Changes:
- Added GraphQL types and fields for app problems (
AppProblem,AppProblemCircuitBreaker,AppProblemCustom) - Created UI components to display problems in a grouped, collapsible format with badges
- Integrated problem display into the installed extensions list with problem counts in header
- Extended webhook delivery errors to be treated as app problems for unified display
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/graphql/types.generated.ts | Auto-generated GraphQL type definitions for app problems and new input types |
| src/graphql/typePolicies.generated.ts | Auto-generated Apollo cache policies for new types |
| src/graphql/hooks.generated.ts | Updated fragment to include problems field |
| src/graphql/fragmentTypes.generated.ts | Updated fragment types to include app problem union types |
| src/fragments/apps.ts | Added problems field to InstalledAppDetails fragment |
| src/extensions/views/InstalledExtensions/hooks/useInstalledExtensions.tsx | Modified to fetch and aggregate problems, including webhook errors |
| src/extensions/views/InstalledExtensions/components/InstalledExtensionsList/InstalledExtensionsList.tsx | Refactored to display expandable problems rows |
| src/extensions/views/InstalledExtensions/components/AppProblems/* | New components for displaying problems (list, badges, cards, type badges) |
| src/extensions/views/InstalledExtensions/InstalledExtensions.tsx | Added problems count badge to header |
| src/extensions/types.ts | Added AppProblem types and WebhookDeliveryProblem interface |
| src/extensions/messages.ts | Added problem-related messages for i18n |
| src/extensions/components/AppAlerts/useAppsAlert.ts | Modified to check for app problems and show alerts |
| src/extensions/components/AppAlerts/SidebarAppAlert.test.tsx | Updated test to mock new query |
| locale/defaultMessages.json | Added new message IDs for problems feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/extensions/views/InstalledExtensions/hooks/useInstalledExtensions.tsx
Outdated
Show resolved
Hide resolved
src/extensions/views/InstalledExtensions/components/AppProblems/ProblemsList.tsx
Outdated
Show resolved
Hide resolved
src/extensions/views/InstalledExtensions/components/AppProblems/ProblemCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/extensions/views/InstalledExtensions/hooks/useInstalledExtensions.tsx
Outdated
Show resolved
Hide resolved
src/extensions/views/InstalledExtensions/hooks/useInstalledExtensions.tsx
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6283 +/- ##
==========================================
+ Coverage 42.67% 42.71% +0.04%
==========================================
Files 2517 2534 +17
Lines 43696 44006 +310
Branches 9954 10434 +480
==========================================
+ Hits 18647 18799 +152
+ Misses 25011 23868 -1143
- Partials 38 1339 +1301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Differences Found✅ No packages or licenses were added. SummaryExpand
|
| Added app problems display to the installed extensions list. Each app now shows reported problems with severity badges, timestamps, and dismissal support. The "Open the app" action link is only shown for third-party apps. Requires Saleor 3.22+. | ||
|
|
||
| :::warning | ||
| This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36). Used with older version, Extensions page will break |
There was a problem hiding this comment.
The changeset warning states this release requires Saleor core 3.22.36, which is a very specific version. Consider whether this should be a minimum version requirement (>=3.22.36) rather than requiring an exact version, unless there's a specific reason for the exact version requirement. This could unnecessarily prevent users from upgrading to newer patch versions of Saleor.
| This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36). Used with older version, Extensions page will break | |
| This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36) or newer in the 3.22 series. Used with older versions, the Extensions page will break. |
saleor/saleor#18724