-
Notifications
You must be signed in to change notification settings - Fork 1.2k
App Problems implementation #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
a045d9b
gql types
lkostrowski 587446a
UI for problems
lkostrowski 7ec2ffe
iteration of ui
lkostrowski 7adfaf3
iteration of ui - better collapse
lkostrowski 805e2a2
UI increments
lkostrowski 3f55c23
fix grouping
lkostrowski 0511c12
refresh types
lkostrowski e635907
refresh ui
lkostrowski bae7e00
Final ui
lkostrowski dfe68b8
link fixes
lkostrowski e0e4f99
Update schema
lkostrowski 8c13b5b
fix types
lkostrowski 2e63600
Clearing problems
lkostrowski b8876de
better message
lkostrowski da97034
Merge branch 'main' into app-problems
lkostrowski f09d4bb
update schema
lkostrowski 1d652e4
apply new api
lkostrowski d30fc9e
update ui
lkostrowski 3b92924
ui fixes
lkostrowski 11227ce
ai fixes
lkostrowski 27acea8
dismissed by
lkostrowski 40d64e8
Replace "Show More" expand with popup dialog for problems list
lkostrowski 0d9c224
hide action if not needed
lkostrowski b45f56e
Merge branch 'main' into app-problems
lkostrowski 0b9f34e
hide problems if no active
lkostrowski ca5b220
update schema
lkostrowski 04ced51
better copy
lkostrowski 952a7c8
update schema
lkostrowski 9d3e760
update codebase
lkostrowski bf4ff20
update schema
lkostrowski 2905850
messages
lkostrowski a3afbd7
storybook
lkostrowski 8be837e
Merge branch 'main' into app-problems
lkostrowski 94ce553
review fixes
lkostrowski 8e098bc
fix dismissal
lkostrowski ee25183
dont render dismiss for manual apps
lkostrowski 36c726a
fix test
lkostrowski b4b0b5f
cr fixes
lkostrowski cc73e07
Update long-rugs-wash.md
lkostrowski 6fc7394
Merge branch 'main' into app-problems
lkostrowski dd9d266
Address PR #6283 review comments
lkostrowski 9d50e94
fixtures and tests
lkostrowski 7607f69
Extract css
lkostrowski 7ecfc45
better colors
lkostrowski 9454cb8
better colors
lkostrowski c3cc602
refactor
lkostrowski 575a503
fix pagination
lkostrowski f7c6717
change useAppsAlert
lkostrowski e968440
test for app alerts
lkostrowski 6370c7b
fix tests
lkostrowski 3793f0a
Merge branch 'main' into app-problems
lkostrowski 7b51326
Merge branch 'main' into app-problems
lkostrowski 587e242
Merge branch 'main' into app-problems
lkostrowski 395eff5
Merge branch 'main' into app-problems
lkostrowski adc7993
Merge branch 'app-problems' of github.com:saleor/saleor-dashboard int…
lkostrowski 86ef2af
update lint
lkostrowski c8e3102
Merge branch 'main' into app-problems
lkostrowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| Added app problems display to the installed extensions list. Each app now shows reported problems with severity badges, timestamps, and dismissal support. The "Open the app" action link is only shown for third-party apps. Requires Saleor 3.22+. | ||
|
|
||
| :::warning | ||
| This release *requires* Saleor core [`3.22.36`](https://github.com/saleor/saleor/releases/tag/3.22.36). Used with older version, Extensions page will break | ||
| ::: | ||
lkostrowski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changeset warning states this release requires Saleor core 3.22.36, which is a very specific version. Consider whether this should be a minimum version requirement (>=3.22.36) rather than requiring an exact version, unless there's a specific reason for the exact version requirement. This could unnecessarily prevent users from upgrading to newer patch versions of Saleor.