Add filtering to assign modal dialog#6327
Merged
witoszekdev merged 18 commits intomainfrom Feb 12, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 025f0f4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6327 +/- ##
==========================================
+ Coverage 42.55% 42.68% +0.13%
==========================================
Files 2499 2505 +6
Lines 43338 43411 +73
Branches 10236 10247 +11
==========================================
+ Hits 18442 18532 +90
- Misses 23580 24841 +1261
+ Partials 1316 38 -1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 11, 2026
lkostrowski
approved these changes
Feb 11, 2026
Comment on lines
+66
to
+77
| const AssignAttributeValueDialog = (props: AssignAttributeValueDialogProps) => { | ||
| const { | ||
| entityType, | ||
| pages, | ||
| products, | ||
| collections, | ||
| categories, | ||
| attribute, | ||
| initialConstraints, | ||
| onFilterChange, | ||
| ...rest | ||
| } = props; |
Member
There was a problem hiding this comment.
I guess not needed change, maybe we can add some static check or claude rule to pick one of the syntaxes so agents dont try to change that with no reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added filtering by "Model type" to Assign modal dialog.
Refactored
AssignContainerRowsso that it supports dialog with filters (generic ui used for all "Assign ..." dialogs except products)