Skip to content

Add filtering to assign modal dialog #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
witoszekdev merged 18 commits into from
Feb 12, 2026

Merge branch 'main' into eng-1192-add-filtering-modals

025f0f4
Select commit
Loading
Failed to load commit list.
Merged

Add filtering to assign modal dialog #6327

Merge branch 'main' into eng-1192-add-filtering-modals
025f0f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2026 in 0s

42.68% (+0.13%) compared to 5669ef5

View this Pull Request on Codecov

42.68% (+0.13%) compared to 5669ef5

Details

Codecov Report

❌ Patch coverage is 71.82320% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.68%. Comparing base (5669ef5) to head (025f0f4).

Files with missing lines Patch % Lines
...lFilters/entityConfigs/ModalPageFilterProvider.tsx 36.84% 12 Missing ⚠️
src/products/views/ProductUpdate/ProductUpdate.tsx 0.00% 11 Missing ⚠️
...ttributeValueDialog/AssignAttributeValueDialog.tsx 25.00% 6 Missing ⚠️
...components/AssignModelDialog/AssignModelDialog.tsx 86.36% 3 Missing ⚠️
src/modeling/views/PageCreate.tsx 0.00% 3 Missing ⚠️
src/modeling/views/PageDetails.tsx 0.00% 3 Missing ⚠️
src/products/views/ProductCreate/ProductCreate.tsx 0.00% 3 Missing ⚠️
...c/products/views/ProductVariant/ProductVariant.tsx 0.00% 3 Missing ⚠️
src/products/views/ProductVariantCreate.tsx 0.00% 3 Missing ⚠️
...ts/AssignContainerDialog/AssignContainerDialog.tsx 95.83% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6327      +/-   ##
==========================================
+ Coverage   42.55%   42.68%   +0.13%     
==========================================
  Files        2499     2505       +6     
  Lines       43338    43411      +73     
  Branches    10236    10247      +11     
==========================================
+ Hits        18442    18532      +90     
- Misses      23580    24841    +1261     
+ Partials     1316       38    -1278

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov