Skip to content

[master] Some more small tests fixes/enhancements#66695

Merged
dwoz merged 6 commits intosaltstack:masterfrom
meaksh:master-some-more-test-fixes
Jan 30, 2026
Merged

[master] Some more small tests fixes/enhancements#66695
dwoz merged 6 commits intosaltstack:masterfrom
meaksh:master-some-more-test-fixes

Conversation

@meaksh
Copy link
Contributor

@meaksh meaksh commented Jul 5, 2024

What does this PR do?

This PR fixes some more detected issue in tests:

  • tests/pytests/functional/modules/test_system.py -> make sure service is not masked to avoid failure
  • salt/auth/pam.py -> make use of sys.executable as fallback when /usr/bin/python3 does not exist. This should make auth.pam module more reliable in certain environments.

This PR fixes #66035

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@meaksh meaksh requested a review from a team as a code owner July 5, 2024 16:11
@meaksh meaksh requested a review from felippeb July 5, 2024 16:11
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Some more small tests fixes/enhancements [master] Some more small tests fixes/enhancements Jul 5, 2024
agraul pushed a commit to agraul/salt that referenced this pull request Jan 27, 2025
* test_system: prevent errors when systemd-timesyncd service is masked

* test_custom_module: disable tests when running on Salt Bundle

* Fix debian 12 package tests

* pam: use sys.executable in case /usr/bin/python3 does not exist

* pam: add unit test to ensure sys.executable is used

* Use proper method to calculate the path to Python interpreter

---------

Co-authored-by: Megan Wilhite <mwilhite@vmware.com>

BACKPORT-UPSTREAM=saltstack#66695
@twangboy twangboy added the test:full Run the full test suite label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] salt-api with PAM authentication and dependency on /usr/bin/python3

3 participants