Skip to content

Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed#1387

Merged
danney-chun merged 5 commits intomainfrom
bug-fix/CLNP-7893-1
Jan 20, 2026
Merged

Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed#1387
danney-chun merged 5 commits intomainfrom
bug-fix/CLNP-7893-1

Conversation

@danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Jan 16, 2026

// PR title (Required)
[fix]: Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed.

// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.

// Footer (Recommended)
Fixes <TICKET_ID>

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.

Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com


### Checklist

Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

- [x] **All tests pass locally with my changes**
- [ ] **I have added tests that prove my fix is effective or that my feature works**
- [ ] **Public components / utils / props are appropriately exported**
- [ ] I have added necessary documentation (if appropriate)


## External Contributions

- Multi Tab 테스트 과정에서 buble typing indecator를 사용을 했을때,  indicator가 2번째로 보여질때 부터 Scroll이 bottome으로 가질 않아, indicator가 보이지 않는 문제가 있어 수정을 했습니다.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 03ab897
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/696ed0b84f47ad0008d202ed
😎 Deploy Preview https://deploy-preview-1387--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danney-chun danney-chun self-assigned this Jan 16, 2026
@danney-chun danney-chun requested a review from bang9 January 16, 2026 05:20
Copy link
Contributor

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

handleScroll?.(true);
}, []);
// Also adjust scroll when typing indicator appears (0 -> 1+)
const shouldAdjustScroll = !didMountRef.current || typingMembers.length > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (typingMembers.length === 0) return null; 로 length가 0일때는 useLayoutEffect 호출이 안되고 typingMembers.length > 0 이상일경우 마운트 이후 첫 호출이 될거라 didMountRef 는 제외 해도 될것 같습니다

@danney-chun danney-chun merged commit 5d04e99 into main Jan 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants