Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed#1387
Merged
danney-chun merged 5 commits intomainfrom Jan 20, 2026
Conversation
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OnestarLee
approved these changes
Jan 19, 2026
| handleScroll?.(true); | ||
| }, []); | ||
| // Also adjust scroll when typing indicator appears (0 -> 1+) | ||
| const shouldAdjustScroll = !didMountRef.current || typingMembers.length > 0; |
Contributor
There was a problem hiding this comment.
if (typingMembers.length === 0) return null; 로 length가 0일때는 useLayoutEffect 호출이 안되고 typingMembers.length > 0 이상일경우 마운트 이후 첫 호출이 될거라 didMountRef 는 제외 해도 될것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// PR title (Required)
[fix]: Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed.
// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.
// Footer (Recommended)
Fixes <TICKET_ID>
// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
Changelogs
// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com