Skip to content

Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danney-chun merged 5 commits into from
Jan 20, 2026
+12 −5
Merged

Fixed a bug where the bubble-type typing indicator did not trigger scrolling to the bottom from the second time it was displayed #1387

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96ebd54
Update index.tsx
danney-chun Jan 16, 2026
50cbbd2
Update index.tsx
danney-chun Jan 18, 2026
ef0a16f
apply feed
danney-chun Jan 19, 2026
893d17a
Update index.tsx
danney-chun Jan 19, 2026
03ab897
changed github token
danney-chun Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/ui/TypingIndicatorBubble/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useLayoutEffect } from 'react';
import React, { useLayoutEffect, useRef } from 'react';
import { Member } from '@sendbird/chat/groupChannel';
import Avatar from '../Avatar';
import TypingDots from './TypingDots';
Expand Down Expand Up @@ -82,11 +82,21 @@ const TypingIndicatorBubbleAvatar = (props: TypingIndicatorBubbleProps) => {

const TypingIndicatorBubble = (props: TypingIndicatorBubbleProps) => {
const { typingMembers, handleScroll } = props;
const didMountRef = useRef(false);

useLayoutEffect(() => {
// Keep the scrollBottom value after fetching new message list
handleScroll?.(true);
}, []);
// Also adjust scroll when typing indicator appears (0 -> 1+)
const shouldAdjustScroll = !didMountRef.current || typingMembers.length > 0;
Copy link
Contributor

@OnestarLee OnestarLee Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (typingMembers.length === 0) return null; 로 length가 0일때는 useLayoutEffect 호출이 안되고 typingMembers.length > 0 이상일경우 마운트 이후 첫 호출이 될거라 didMountRef 는 제외 해도 될것 같습니다

didMountRef.current = true;
if (!shouldAdjustScroll) return;
const rafId = requestAnimationFrame(() => {
handleScroll?.(true);
});
return () => {
cancelAnimationFrame(rafId);
};
}, [handleScroll, typingMembers.length]);

if (typingMembers.length === 0) return null;

Expand Down