Merged
Conversation
diegomrsantos
force-pushed
the
cache-deps
branch
2 times, most recently
from
7897f3b to
c5b6646
Compare
diegomrsantos
force-pushed
the
cache-deps
branch
from
c5b6646 to
3a4649d
Compare
diegomrsantos
commented
Mar 14, 2025
| # Clippy lints are opt-in per-crate for now. By default, everything is allowed except for performance and correctness lints. | ||
| lint: | ||
| cargo clippy --workspace --tests $(EXTRA_CLIPPY_OPTS) --features "$(TEST_FEATURES)" -- \ | ||
| cargo clippy --workspace --tests --no-deps $(EXTRA_CLIPPY_OPTS) --features "$(TEST_FEATURES)" -- \ |
Member
Author
There was a problem hiding this comment.
Even with this flag, the dependencies are still being checked.
diegomrsantos
commented
Mar 14, 2025
| with: | ||
| cache: false | ||
| channel: stable | ||
| cache: true |
Member
Author
There was a problem hiding this comment.
Was it intentional to set the cache to false?
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to speed up CI builds by caching Rust dependencies within the GitHub workflows.
- Added manual trigger capability via workflow_dispatch.
- Updated caching configuration for various jobs by switching from cache: false to cache: true and setting appropriate cache-target values (release or debug).
- Corrected caching setup in the check-msrv job structure.
Member
jking-aus
approved these changes
Mar 21, 2025
Member
|
Did anyone have the chance to review the issue I flagged above? @diegomrsantos |
Member
this only occurs when the code is built multiple times on the same runner? I will try and force this issue to happen -- if it does we'll roll back the cache change. |
diegomrsantos
added a commit
to diegomrsantos/anchor
that referenced
this pull request
Apr 9, 2025
This reverts commit a9c6b48.
diegomrsantos
added a commit
to diegomrsantos/anchor
that referenced
this pull request
Apr 9, 2025
This reverts commit a9c6b48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Speeds up CI builds by caching Rust dependencies.
Proposed Changes
These changes will speed up CI by reusing dependencies between workflow runs, significantly reducing build times after the first run.