Skip to content

Rust Dependency Caching #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jking-aus merged 2 commits into from
Mar 21, 2025
Merged

Rust Dependency Caching #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c5edf
Rust dependency caching
diegomrsantos Mar 14, 2025
3a4649d
dont lint deps
diegomrsantos Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
merge_group:
workflow_dispatch: # Add manual trigger capability

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -77,8 +78,8 @@ jobs:
if: env.SELF_HOSTED_RUNNERS == 'false'
uses: moonrepo/setup-rust@v1
with:
cache: false
channel: stable
cache: true
Copy link
Member Author

@diegomrsantos diegomrsantos Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to set the cache to false?

cache-target: release
bins: cargo-nextest
env:
Expand All @@ -102,8 +103,9 @@ jobs:
if: env.SELF_HOSTED_RUNNERS == 'false'
uses: moonrepo/setup-rust@v1
with:
cache: false
channel: stable
cache: true
cache-target: debug
bins: cargo-nextest
- name: Run tests in debug
run: make nextest-debug
Expand All @@ -121,6 +123,7 @@ jobs:
uses: moonrepo/setup-rust@v1
with:
channel: stable
cache: true
cache-target: release
components: rustfmt,clippy
bins: cargo-audit
Expand Down Expand Up @@ -163,7 +166,8 @@ jobs:
with:
channel: nightly
bins: cargo-udeps
cache: false
cache: true
cache-target: debug
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Create Cargo config dir
Expand Down Expand Up @@ -211,6 +215,7 @@ jobs:
uses: moonrepo/setup-rust@v1
with:
channel: stable
cache: true
cache-target: release
bins: cargo-sort, taplo-cli
- name: Run cargo sort to check if Cargo.toml files are sorted
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ test-full: cargo-fmt test-release test-debug
# Lints the code for bad style and potentially unsafe arithmetic using Clippy.
# Clippy lints are opt-in per-crate for now. By default, everything is allowed except for performance and correctness lints.
lint:
cargo clippy --workspace --tests $(EXTRA_CLIPPY_OPTS) --features "$(TEST_FEATURES)" -- \
cargo clippy --workspace --tests --no-deps $(EXTRA_CLIPPY_OPTS) --features "$(TEST_FEATURES)" -- \
Copy link
Member Author

@diegomrsantos diegomrsantos Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with this flag, the dependencies are still being checked.

-D warnings

# Lints the code using Clippy and automatically fix some simple compiler warnings.
Expand Down