Skip to content

Comments

add --enable-high-validator-count-metrics#307

Merged
dknopik merged 1 commit intosigp:unstablefrom
dknopik:high-validator-metrics
May 7, 2025
Merged

add --enable-high-validator-count-metrics#307
dknopik merged 1 commit intosigp:unstablefrom
dknopik:high-validator-metrics

Conversation

@dknopik
Copy link
Member

@dknopik dknopik commented May 7, 2025

add CLI flag to specify if we should enable per validator metrics if we have a high validator count

@dknopik dknopik mentioned this pull request May 7, 2025
@diegomrsantos diegomrsantos requested a review from Copilot May 7, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CLI flag (--enable-high-validator-count-metrics) which enables per validator metrics for high validator counts.

  • In lib.rs, the code now leverages the new flag in the client builder.
  • In config.rs, a configuration field is added with a default value to control this feature.
  • In cli.rs, the new flag is defined using clap with appropriate help text and display options.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
anchor/client/src/lib.rs Uncomments the enable_high_validator_count_metrics configuration in the client builder.
anchor/client/src/config.rs Adds the enable_high_validator_count_metrics field to the Config struct and initializes it.
anchor/client/src/cli.rs Introduces the --enable-high-validator-count-metrics flag via clap with detailed help text.

Copy link
Member

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for handling this!

@dknopik dknopik merged commit 0278baa into sigp:unstable May 7, 2025
11 checks passed
@dknopik dknopik deleted the high-validator-metrics branch June 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants