Skip to content

add --enable-high-validator-count-metrics #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dknopik merged 1 commit into from
May 7, 2025
Merged

add --enable-high-validator-count-metrics #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions anchor/client/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,16 @@ pub struct Node {
)]
pub metrics_port: Option<u16>,

#[clap(
long,
help = "Enable per validator metrics for > 64 validators. \
Note: This flag is automatically enabled for <= 64 validators. \
Enabling this metric for higher validator counts will lead to higher volume \
of prometheus metrics being collected.",
display_order = 0,
help_heading = FLAG_HEADER
)]
pub enable_high_validator_count_metrics: bool,
// TODO: Metrics CORS Origin
// https://github.com/sigp/anchor/issues/249
#[clap(
Expand Down
5 changes: 5 additions & 0 deletions anchor/client/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ pub struct Config {
pub network: network::Config,
/// Configuration for the HTTP REST API.
pub http_metrics: http_metrics::Config,
/// Should we gather per validator metrics for > 64 validators.
pub enable_high_validator_count_metrics: bool,
/// A list of custom certificates that the validator client will additionally use when
/// connecting to a beacon node over SSL/TLS.
pub beacon_nodes_tls_certs: Option<Vec<PathBuf>>,
Expand Down Expand Up @@ -112,6 +114,7 @@ impl Config {
use_long_timeouts: false,
http_api: <_>::default(),
http_metrics: <_>::default(),
enable_high_validator_count_metrics: false,
network: <_>::default(),
beacon_nodes_tls_certs: None,
execution_nodes_tls_certs: None,
Expand Down Expand Up @@ -257,6 +260,8 @@ pub fn from_cli(cli_args: &Node) -> Result<Config, String> {
config.http_metrics.listen_port = port;
}

config.enable_high_validator_count_metrics = cli_args.enable_high_validator_count_metrics;

// debugging stuff
config.impostor = cli_args.impostor.map(OperatorId);

Expand Down
6 changes: 2 additions & 4 deletions anchor/client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ impl Client {
.validator_store(validator_store.clone())
.spec(spec.clone())
.executor(executor.clone())
//.enable_high_validator_count_metrics(config.enable_high_validator_count_metrics)
.enable_high_validator_count_metrics(config.enable_high_validator_count_metrics)
.distributed(true)
.build()?,
);
Expand All @@ -502,8 +502,6 @@ impl Client {
.beacon_nodes(beacon_nodes.clone())
.executor(executor.clone())
.chain_spec(spec.clone());
//.graffiti(config.graffiti)
//.graffiti_file(config.graffiti_file.clone());

// If we have proposer nodes, add them to the block service builder.
if proposer_nodes.num_total().await > 0 {
Expand Down Expand Up @@ -703,7 +701,7 @@ async fn wait_for_genesis(
tokio::select! {
result = poll_whilst_waiting_for_genesis(beacon_nodes, genesis_time) => result?,
() = sleep(genesis_time - now) => ()
};
}

info!(
ms_since_genesis = (genesis_time - now).as_millis(),
Expand Down