fix: Use correct slot for validator registration signature message#659
Merged
mergify[bot] merged 2 commits intosigp:release-v1.0.0from Oct 9, 2025
Merged
Conversation
dknopik
added
ready-for-review
petarjuki7
approved these changes
Oct 8, 2025
dknopik
added
ready-for-merge
and removed
ready-for-review
17 tasks
petarjuki7
pushed a commit
to petarjuki7/anchor
that referenced
this pull request
Oct 16, 2025
…igp#659) - sigp#634 did not fix registrations correctly: while `sign_validator_registration_data` needs to use the beginning of the epoch for the timestamp, for the signature collection slot, we need to use the actual slot passed in via `validator_registration_data`. Separately track `duty_slot` and `epoch_start_slot` and extend the comment to explain. Co-Authored-By: Daniel Knopik <daniel@dknopik.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
sign_validator_registration_dataneeds to use the beginning of the epoch for the timestamp, for the signature collection slot, we need to use the actual slot passed in viavalidator_registration_data.Proposed Changes
Separately track
duty_slotandepoch_start_slotand extend the comment to explain.