Skip to content

fix: Use correct slot for validator registration signature message #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Oct 9, 2025
Merged

fix: Use correct slot for validator registration signature message #659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773d118
fix: Use correct slot for validator registration signature message
dknopik Oct 7, 2025
318a18e
Merge branch 'release-v1.0.0' into fix-message-slot-for-registration
dknopik Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions anchor/validator_store/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,16 +1086,20 @@ impl<T: SlotClock, E: EthSpec> ValidatorStore for AnchorValidatorStore<T, E> {
let (validator, cluster) =
self.get_validator_and_cluster(validator_registration_data.pubkey)?;

// SSV always uses the start of the current epoch, so we need to convert to that
let epoch = self
// Go-SSV always uses the start of the current epoch for the timestamp in
// `ValidatorRegistrationData`, so we need to convert to that. However, it uses the duty
// slot (which is passed in) for the signature message, so we need to pass that to
// `collect_signature`.
let duty_slot = self
.slot_clock
.slot_of(Duration::from_secs(validator_registration_data.timestamp))
.ok_or(SpecificError::SlotClock)?
.epoch(E::slots_per_epoch());
let slot = epoch.start_slot(E::slots_per_epoch());
.ok_or(SpecificError::SlotClock)?;
let epoch_start_slot = duty_slot
.epoch(E::slots_per_epoch())
.start_slot(E::slots_per_epoch());
let duration = self
.slot_clock
.start_of(slot)
.start_of(epoch_start_slot)
.ok_or(SpecificError::SlotClock)?;
let validator_registration_data = ValidatorRegistrationData {
timestamp: duration.as_secs(),
Expand All @@ -1112,7 +1116,7 @@ impl<T: SlotClock, E: EthSpec> ValidatorStore for AnchorValidatorStore<T, E> {
&validator,
&cluster,
signing_root,
slot,
duty_slot,
)
.await?;

Expand Down