fix: auto-populate ENR UDP port from discovery listen port#8804
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Feb 12, 2026
Merged
fix: auto-populate ENR UDP port from discovery listen port#8804mergify[bot] merged 1 commit intosigp:unstablefrom
mergify[bot] merged 1 commit intosigp:unstablefrom
Conversation
When --discovery-port is set without --enr-udp-port, the UDP port was missing from the ENR. TCP and QUIC ports already had fallback logic to use the listen port, but UDP did not. This adds the same .or_else() fallback for udp4/udp6 using disc_port from listen addresses.
|
|
pawanjay176
approved these changes
Feb 12, 2026
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR.
Paging @jxs for checking if we are missing anything
jxs
approved these changes
Feb 12, 2026
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
thanks for this, and thanks for the ping Pawan! LGTM
Merge Queue StatusRule:
This pull request spent 32 minutes 3 seconds in the queue, including 28 minutes 34 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--discovery-portis set without--enr-udp-port, the UDP port was missing from the ENR. TCP and QUIC ports already had fallback logic to use the listen port, but UDP did not. This adds the same .or_else()fallback for udp4/udp6 using disc_port from listen addresses.