Skip to content

Conversation

@myieye
Copy link
Collaborator

@myieye myieye commented Feb 11, 2026

No description provided.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Feb 11, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This PR updates locale files (.po) across the frontend viewer for Spanish, French, Indonesian, Korean, Malaysian, Swahili, and Vietnamese. Changes include updating PO-Revision-Date metadata timestamps and adding or refining translations for UI strings related to publications, filters, recording prompts, and preview messages.

Changes

Cohort / File(s) Summary
Spanish, French, Indonesian, Korean, Vietnamese Translation Updates
frontend/viewer/src/locales/es.po, frontend/viewer/src/locales/fr.po, frontend/viewer/src/locales/id.po, frontend/viewer/src/locales/ko.po, frontend/viewer/src/locales/vi.po
Updated PO-Revision-Date metadata and added or refined translations for publication labels, filter headers, recording instructions, preview availability messages, and related UI strings.
Malaysian and Swahili Metadata Updates
frontend/viewer/src/locales/ms.po, frontend/viewer/src/locales/sw.po
Updated PO-Revision-Date metadata and added trailing newline formatting; no translation content changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • imnasnainaec

Poem

🐰 A rabbit hops through translation lands,
Seven tongues now flow through seeking hands,
From filters bright to recordings clear,
Published words now for all to hear!
Metadata fresh and strings aligned,
A localization gift, refined.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset. Consider adding a brief description explaining the scope of translation updates (e.g., which locales were updated and any notable changes) to improve clarity for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'New Crowdin updates' accurately describes the main changeset, which consists entirely of translation file updates from Crowdin across multiple locales.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch l10n_develop

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

UI unit Tests

 1 files  ±  0   3 suites   - 47   0s ⏱️ -24s
10 tests  - 128  10 ✅  - 128  0 💤 ±0  0 ❌ ±0 
10 runs   - 193  10 ✅  - 193  0 💤 ±0  0 ❌ ±0 

Results for commit e05c56c. ± Comparison against base commit e2d0864.

This pull request removes 138 and adds 10 tests. Note that renamed tests count towards both.
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > accepts parent values when not dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > does NOT guard against stomping deep changes, because StompGuard can't detect them
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > ignores parent values when dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > initializes with the parent value
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > keeps subscribers up to date when it becomes dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > pushs changes to parent
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > reverts new parent values when ignored
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > starts accepting parent changes again after a flush
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations with smallest unit
…
src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser

@myieye myieye merged commit 7995859 into develop Feb 11, 2026
10 of 11 checks passed
@myieye myieye deleted the l10n_develop branch February 11, 2026 13:39
@argos-ci
Copy link

argos-ci bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Feb 11, 2026, 1:40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant