Automatically add `smithy.framework#ValidationException` to constrained operations by drganjoo · Pull Request #4506 · smithy-lang/smithy-rs

drganjoo · 2026-01-28T17:35:54Z

Previously, users had to set addValidationExceptionToConstrainedOperations: true
or manually add ValidationException to each operation with constrained inputs.
Now ValidationException is automatically added unless a custom validation exception
(with @validationException trait) exists in the model.

Change addValidationExceptionToConstrainedOperations from Boolean to nullable
Detect custom validation exceptions via @validationException trait
Skip automatic addition when custom validation exception is defined
Add deprecation warning when flag is explicitly set to true
Update tests to verify automatic and custom validation behavior
Update AGENTS.md with codegen settings documentation

Closes: 4494

Previously, users had to set `addValidationExceptionToConstrainedOperations: true` or manually add ValidationException to each operation with constrained inputs. Now ValidationException is automatically added unless a custom validation exception (with @validationException trait) exists in the model. - Change `addValidationExceptionToConstrainedOperations` from Boolean to nullable - Detect custom validation exceptions via @validationException trait - Skip automatic addition when custom validation exception is defined - Add deprecation warning when flag is explicitly set to true - Update tests to verify automatic and custom validation behavior - Update AGENTS.md with codegen settings documentation

rcoh · 2026-01-29T02:05:08Z

...rver/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ServerRustSettings.kt

+    /**
+     * @deprecated This flag is deprecated. `smithy.framework#ValidationException` is now automatically added to operations
+     * with constrained inputs unless a custom validation exception (a structure with the `@validationException`
+     * trait) is defined in the model. Setting this to false will disable the automatic addition, but this
+     * behavior is deprecated and may be removed in a future release.
+     */
+    val addValidationExceptionToConstrainedOperations: Boolean? = null,


what if a constraint trait is removed? Does that cause a breaking change in clients? Not sure we need to worry about it but worth considering. I guess validation exception is "hidden" in that only the server actually cares about it?

github-actions · 2026-01-29T12:39:45Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-01-29T16:41:53Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-01-29T19:08:11Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-04T18:30:52Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-04T21:22:13Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-05T22:46:52Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-06T01:41:28Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-06T21:28:40Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 · 2026-02-12T16:41:47Z

As an additional (interactive) test, let's make sure that the changes pass ./gradlew codegen-server-test:test for Smithy version 1.67.0.

github-actions · 2026-02-12T16:55:31Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-12T18:21:30Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

As detailed in #3813, each event stream operation must have ValidationException attached. This is necessary because when an operation's input includes an event streaming member, the builder for the operation input or output can raise a ConstraintViolation if build_enforcing_all_constraints is called and the event streaming member field has not been set.

github-actions · 2026-02-12T20:27:42Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-12T22:34:01Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-13T01:01:07Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 · 2026-02-13T16:37:09Z

Looks like the current HEAD e017301 never finishes check-server-codegen-unit-tests (ran it locally and didn't finish after 1 hour).

drganjoo · 2026-02-13T18:25:55Z

Looks like the current HEAD e017301 never finishes check-server-codegen-unit-tests (ran it locally and didn't finish after 1 hour).

I'm investigating the issue now and will push a fix once I identify the root cause.

github-actions · 2026-02-13T18:49:27Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-13T19:46:12Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2026-02-13T20:48:04Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

## Motivation and Context P382257849 ## Description Changes on the client side: - [x] Remove extra rest json tests that are officially part of Smithy protocol tests in 1.64.0 - [x] Filter out newly added model in `SmithyTypesPubUseExtraTest.kt` that would otherwise defeat the purpose of the test Changes on the server side: - [x] Address errors related to server's constraint types (#4506) - [x] #4535 - [x] #4537 ## Testing - CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Fahad Zubair <fahadzubair@gmail.com> Co-authored-by: Fahad Zubair <fahadzub@amazon.com>

drganjoo requested review from a team as code owners January 28, 2026 17:35

rcoh approved these changes Jan 29, 2026

View reviewed changes

Use orElse to convert optional to boolean

a21564a

drganjoo force-pushed the fahadzub/add-validation-auto branch from 33d0826 to a21564a Compare January 29, 2026 12:15

Fix changelog reference

f9bd664

Merge branch 'main' into fahadzub/add-validation-auto

56cb125

Merge branch 'main' into fahadzub/add-validation-auto

04c3f6b

Merge branch 'main' into fahadzub/add-validation-auto

f3f855a

Merge branch 'main' into fahadzub/add-validation-auto

b65681b

Bump codegen version

d8732fa

Merge branch 'main' into fahadzub/add-validation-auto

64f7712

Merge branch 'main' into fahadzub/add-validation-auto

9a9243b

drganjoo and others added 2 commits February 12, 2026 17:33

Merge branch 'main' into fahadzub/add-validation-auto

d346490

Update codegen-version

911009e

ysaito1001 mentioned this pull request Feb 12, 2026

Bump Smithy to 1.67.0 #4533

Merged

5 tasks

Make sdk-lockfiles aware of metrics-related server crates

e017301

ysaito1001 enabled auto-merge February 12, 2026 23:17

Merge branch 'main' into fahadzub/add-validation-auto

c4b3ea6

Experimental setting should be checked

6dec72a

Test for validationexception missing should explictly disable flag

487dd1f

ysaito1001 approved these changes Feb 13, 2026

View reviewed changes

ysaito1001 merged commit a02bab9 into main Feb 13, 2026
50 checks passed

ysaito1001 deleted the fahadzub/add-validation-auto branch February 13, 2026 21:25

Conversation

drganjoo commented Jan 28, 2026

Uh oh!

rcoh Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

ysaito1001 commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

ysaito1001 commented Feb 13, 2026

Uh oh!

drganjoo commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants