Skip to content

Update smithy-rules-engine-tests with new std lib functions and bdd-based tests#2945

Merged
sugmanue merged 8 commits intosmithy-lang:mainfrom
landonxjames:landonxjames/bdd-tests
Jan 29, 2026
Merged

Update smithy-rules-engine-tests with new std lib functions and bdd-based tests#2945
sugmanue merged 8 commits intosmithy-lang:mainfrom
landonxjames:landonxjames/bdd-tests

Conversation

@landonxjames
Copy link
Contributor

@landonxjames landonxjames commented Jan 26, 2026

Background

  • What do these changes do?
  • Why are they important?

Add new tests for the new coalesce, split, and ite std lib functions.

Work to automate adding the endpointBdd trait to these test models is tracked in #2949.

Testing

  • How did you test these changes?

I believe these are tested on build so will be tested by CI. Also tested these against the Rust test generator.

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2945" --type feature --description "Update smithy-rules-engine-tests with new std lib functions and bdd-based tests"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

@landonxjames landonxjames marked this pull request as ready for review January 26, 2026 21:23
@landonxjames landonxjames requested a review from a team as a code owner January 26, 2026 21:23
@landonxjames landonxjames requested a review from sugmanue January 26, 2026 21:23
@landonxjames
Copy link
Contributor Author

Capturing offline discussion with @sugmanue:

  • Use the same namespace for all of the tests namespace smithy.rules.tests
  • Combine the bdd-tests and tree-tests into a single model for each std-lib fn that contains both traits
  • Eventually will be better if the endpointBdd trait can just be provided as a transformation/part of the model projection so that we don't have to worry about manually compiling it and keeping it in sync (@sugmanue to own this part)

Note the split model currently won't compile due to the bug fixed in
smithy-lang#2946

Commiting so I can pull that change in and regenerate
@sugmanue sugmanue merged commit 8c966a2 into smithy-lang:main Jan 29, 2026
13 checks passed
milesziemer added a commit that referenced this pull request Jan 29, 2026
milesziemer added a commit that referenced this pull request Jan 29, 2026
…nd bdd-based tests (#2945)" (#2950)

This reverts commit 8c966a2.

Will include in next Smithy version.
milesziemer added a commit that referenced this pull request Jan 29, 2026
sugmanue pushed a commit that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants