Update smithy-rules-engine-tests with new std lib functions and bdd-based tests#2945
Merged
sugmanue merged 8 commits intosmithy-lang:mainfrom Jan 29, 2026
Merged
Conversation
Also split tests into separate bdd-tests and tree-tests folders
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
Contributor
Author
|
Capturing offline discussion with @sugmanue:
|
Note the split model currently won't compile due to the bug fixed in smithy-lang#2946 Commiting so I can pull that change in and regenerate
Automating adding them back is tracked in smithy-lang#2949
sugmanue
requested changes
Jan 28, 2026
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/coalesce.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/default-values.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/endpoint-bindings.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/endpoints-string-array.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/get-attr.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/parse-url.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/split.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/substring.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/url-encode.smithy
Outdated
Show resolved
Hide resolved
smithy-rules-engine-tests/src/main/resources/META-INF/smithy/valid-hostlabel.smithy
Outdated
Show resolved
Hide resolved
sugmanue
approved these changes
Jan 28, 2026
sugmanue
pushed a commit
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add new tests for the new
coalesce,split, anditestd lib functions.Work to automate adding the
endpointBddtrait to these test models is tracked in #2949.Testing
I believe these are tested on build so will be tested by CI. Also tested these against the Rust test generator.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.