fix: use getReleaseByTag API instead of iterating all releases#725
Open
kim-em wants to merge 1 commit intosoftprops:masterfrom
Open
fix: use getReleaseByTag API instead of iterating all releases#725kim-em wants to merge 1 commit intosoftprops:masterfrom
kim-em wants to merge 1 commit intosoftprops:masterfrom
Conversation
This avoids GitHub's API pagination limit of 10000 results which causes failures for repositories with many releases. The `findTagFromReleases` function now uses the direct `getReleaseByTag` API for O(1) lookup instead of iterating through all releases with `allReleases`. This is both more efficient and fixes the 10k limit issue. Fixes softprops#724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #724 by using the direct
getReleaseByTagAPI instead of iterating through all releases.Problem
The
findTagFromReleasesfunction previously iterated through all releases usingallReleases()to find a matching tag. This fails when the repository has more than 10,000 releases due to GitHub's API pagination limit:Solution
The
GitHubReleaserclass already has agetReleaseByTagmethod that fetches a release directly by tag. This PR updatesfindTagFromReleasesto use this direct lookup:Changes
src/github.ts: UpdatedfindTagFromReleasesto usegetReleaseByTagwith proper 404 handling__tests__/github.test.ts: Updated tests to reflect the new implementationdist/index.js: RebuiltTesting
All existing tests pass. Updated the
findTagFromReleasestests to verify: