Replace privileged: true with fine grained capabilities#1209
Merged
pstranak-sw merged 2 commits intomasterfrom Dec 3, 2025
Merged
Replace privileged: true with fine grained capabilities#1209pstranak-sw merged 2 commits intomasterfrom
privileged: true with fine grained capabilities#1209pstranak-sw merged 2 commits intomasterfrom
Conversation
jakub-racek-swi
approved these changes
Nov 26, 2025
Contributor
jakub-racek-swi
left a comment
jakub-racek-swi
left a comment
There was a problem hiding this comment.
lgtm, surely you've verified it works 👍
gantrior
approved these changes
Nov 27, 2025
pstranak-sw
reviewed
Nov 27, 2025
| @@ -32,7 +32,21 @@ spec: | |||
| image: "{{ include "common.image" (tuple . .Values.network_topology (tuple "image" "obi")) }}" | |||
| imagePullPolicy: {{ .Values.network_topology.image.pullPolicy }} | |||
| securityContext: | |||
Contributor
There was a problem hiding this comment.
I would make this configurable:
- If
.Values.network_topology.privilegedis set, put hereprivileged: true. - Else if
.Values.network_topology.securityContextis set, put its content here. - Else put these default values here.
pstranak-sw
deleted the
chore/replace-privileged-with-fine-grained-capabilities
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
privileged: truewith fine grained capabilities according to documentation.