Skip to content

Replace privileged: true with fine grained capabilities #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstranak-sw merged 2 commits into from
Dec 3, 2025
Merged

Replace privileged: true with fine grained capabilities #1209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd193a
chore: replaced privileged with fine grained capabilities
turytsia Nov 26, 2025
a112a8a
Merge branch 'master' into chore/replace-privileged-with-fine-grained…
turytsia Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion deploy/helm/templates/obi/daemon-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,21 @@ spec:
image: "{{ include "common.image" (tuple . .Values.network_topology (tuple "image" "obi")) }}"
imagePullPolicy: {{ .Values.network_topology.image.pullPolicy }}
securityContext:
Copy link
Contributor

@pstranak-sw pstranak-sw Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this configurable:

  1. If .Values.network_topology.privileged is set, put here privileged: true.
  2. Else if .Values.network_topology.securityContext is set, put its content here.
  3. Else put these default values here.

privileged: true
runAsUser: 0
readOnlyRootFilesystem: true
capabilities:
add:
- BPF
- PERFMON
- DAC_READ_SEARCH
- CHECKPOINT_RESTORE
- NET_RAW
- NET_ADMIN
- SYS_PTRACE
- SYS_ADMIN
- SYS_RESOURCE
drop:
- ALL
ports:
{{- if .Values.network_topology.config.prometheus_export }}
- name: metrics
Expand Down
Loading