Skip to content

Conversation

@lorenyu
Copy link

@lorenyu lorenyu commented Apr 11, 2025

Resolves #1574

Changes

This change fixes the bug reported in #1574

Testing

I created a minimal reproduction of the error in this repository: https://github.com/navapbc/ruby-steep-bug-repro

Before any changes were made, running bundle exec steep check within the folder \{\{foo\}\} could not find the type error, even though running the same command in the identical folder foo could find it.

image

After editing steep locally with the changes, running bundle exec steep check within the \{\{foo\}\} folder now properly detects the type error:

image

@lorenyu
Copy link
Author

lorenyu commented Apr 17, 2025

@soutaro hi can you take a look at this? This is currently a blocking issue preventing me from being able to adopt rbs on my project.

@lorenyu
Copy link
Author

lorenyu commented Apr 23, 2025

@tk0miya sorry to bother you but I saw you are active on other issues so I wonder if maybe you might have some time to review? My project is blocked on this issue and I already spent the time to produce a fix so I would appreciate it if one of the repository maintainers can review and merge the fix.

Copy link
Contributor

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with nits.

Note: I'm not a maintainer. So the only thing I can do is review. Please ask soutaro about merging.

@lorenyu
Copy link
Author

lorenyu commented Apr 30, 2025

@soutaro it looks like @tk0miya did a review and I've made the suggested nit changes from that review. I was wondering if you could take a look and merge this change. As I mentioned previously, my project would like to use rbs but is currently blocked on being able to use it due to this issue, and I can't figure out a reasonable workaround. It's a bit of a long story why we have special characters in our path but it's not something we can easily change.

@lorenyu lorenyu changed the title Escape special characters in path before globbing Handle special characters in path when globbing May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Steep fails to find files to typecheck when running from within a directory that contains curly braces in its path

2 participants