Skip to content

Handle special characters in path when globbing #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenyu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle special characters in path when globbing #1575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b715bee
Escape special characters in path before globbing
lorenyu Apr 11, 2025
0c63fe5
Use Pathname(dir).glob instead of escaping dir
lorenyu Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/steep/services/file_loader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ def each_path_in_patterns(pattern, commandline_patterns = [])
pats = commandline_patterns.empty? ? pattern.patterns : commandline_patterns

pats.each do |path|
Pathname.glob((base_dir + path).to_s).each do |absolute_path|
Pathname(base_dir).glob(path.to_s).each do |absolute_path|
if absolute_path.file?
relative_path = absolute_path.relative_path_from(base_dir)
if pattern =~ relative_path
yield relative_path
end
else
files = Pathname.glob("#{absolute_path}/**/*#{pattern.ext}")
files = Pathname(absolute_path).glob("**/*#{pattern.ext}")

files.sort.each do |source_path|
if source_path.file?
Expand Down