Refactor: Gas tile overlay split#42881
Open
insoPL wants to merge 5 commits intospace-wizards:masterfrom
Open
Conversation
PJBot
added
S: Untriaged
ArtisticRoomba
added
P3: Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Gas tile overlay was doing too much both networking and creation of overlay for fire and visible gas. This PR extracts overlay creation into separate files and creates separate overlays for fire and visible gas.
#4625
Why / Balance
Technical details
Media
Requirements
Breaking changes
New enum value for
public enum DrawDepth
Changelog