Add version catalogue files to JUnit change detection#1429
Open
dwittkoetter wants to merge 1 commit intospring-projects:mainfrom
Open
Add version catalogue files to JUnit change detection#1429dwittkoetter wants to merge 1 commit intospring-projects:mainfrom
dwittkoetter wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Dennis Wittkötter <dw@logentis.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using Gradle's Version Catalogue in our project to specify dependencies outside of the
build.gradle(.kts). Instead, all dependencies and their versions are located in agradle/libs.versions.tomlfile. Currently, this file is not included in the specified build files for the change detection. The JUnit extension fromspring-modulith-junitwill not detect changes in those files and therefore version updates will not back off the optimization of the module test execution.I prepared this PR so the
libs.versions.tomlfile is recognized byOtherFileChange.