Merged
Conversation
GalRogozinski
requested changes
Feb 20, 2025
Contributor
GalRogozinski
left a comment
There was a problem hiding this comment.
When we do the tests itself it is arguably fine to copy paste
but we shouldn't do it for writing utils code
maybe create a function called SortedMapKeys that uses generics, and put it in a utils file:
// SortMapByKey sorts a map by its keys and returns a sorted slice of key-value pairs.
func SortedMapKeys[K constraints.Ordered, V any](m map[K]V) []struct {
Key K
Value V
} {
// Extract and sort keys
keys := make([]K, 0, len(m))
for k := range m {
keys = append(keys, k)
}
sort.Slice(keys, func(i, j int) bool { return keys[i] < keys[j] })
// Create sorted key-value pairs
pairs := make([]struct {
Key K
Value V
}, len(keys))
for i, k := range keys {
pairs[i] = struct {
Key K
Value V
}{k, m[k]}
}
return pairs
}
MatusKysel
approved these changes
Feb 20, 2025
Contributor
Author
|
@GalRogozinski added the generic function. Pls let me know if it's ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the test entropy, created in the Electra change, that uses randomly sorted validator indexes in messages.