Skip to content

fix ssvmsg MessageIDs to map to a different role#560

Merged
GalRogozinski merged 5 commits intossvlabs:mainfrom
Zacholme7:fix-messageids
Jul 17, 2025
Merged

fix ssvmsg MessageIDs to map to a different role#560
GalRogozinski merged 5 commits intossvlabs:mainfrom
Zacholme7:fix-messageids

Conversation

@Zacholme7
Copy link
Contributor

@Zacholme7 Zacholme7 commented Jul 2, 2025

for test1 and test2 the role is either invalid, or maps to committee.

We differentiate between a committee and validator duty executor and enforce that you can only access the public key through the duty executor if the role is not committee. This pr modifies the message ids so that they map to a different role.

Please let me know if we are too strict here. Thanks!

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Thanks for contributing!
As you may have guessed from folder name the jsons are generated.
Can you please:

  1. revert
  2. change types/spectest/tests/ssvmsg/msg_id_belongs.go
  3. change msg_id_doesnt_belong.go
  4. make generate-jsons (there's also a way to not run it for the whole project, but always safer to do it this way)

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Tom-ssvlabs Tom-ssvlabs removed their request for review July 16, 2025 10:55
@GalRogozinski GalRogozinski merged commit f648f22 into ssvlabs:main Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants