Skip to content

fix ssvmsg MessageIDs to map to a different role #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GalRogozinski merged 5 commits into from
Jul 17, 2025
Merged

fix ssvmsg MessageIDs to map to a different role #560

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cb3d96
fix message id
Zacholme7 Jul 2, 2025
b796873
Revert "fix message id"
Zacholme7 Jul 8, 2025
886e0cb
adjust test setup for generation
Zacholme7 Jul 8, 2025
c78b61e
remove duplicates
Zacholme7 Jul 15, 2025
ae6b4c0
Merge branch 'main' into fix-messageids
Zacholme7 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qbft/messages_encoding.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/beacon_types_encoding.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions types/spectest/generate/state_comparison/ssvmsg_SSVMessageTest/ssvmessage belongs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
0,
3,
1,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -64,10 +64,10 @@
0,
3,
1,
255,
255,
255,
255,
1,
0,
0,
0,
142,
128,
6,
Expand Down Expand Up @@ -122,7 +122,7 @@
153,
153,
153,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -180,10 +180,10 @@
153,
153,
153,
255,
255,
255,
255,
1,
0,
0,
0,
142,
128,
6,
Expand Down
20 changes: 10 additions & 10 deletions .../spectest/generate/state_comparison/ssvmsg_SSVMessageTest/ssvmessage does not belong.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
0,
3,
1,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -64,10 +64,10 @@
0,
3,
1,
255,
255,
255,
255,
1,
0,
0,
0,
148,
143,
180,
Expand Down Expand Up @@ -122,7 +122,7 @@
153,
153,
153,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -180,10 +180,10 @@
153,
153,
153,
255,
255,
255,
255,
1,
0,
0,
0,
148,
143,
180,
Expand Down
20 changes: 10 additions & 10 deletions types/spectest/generate/tests/ssvmsg.SSVMessageTest_ssvmessage_belongs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
0,
3,
1,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -64,10 +64,10 @@
0,
3,
1,
255,
255,
255,
255,
1,
0,
0,
0,
142,
128,
6,
Expand Down Expand Up @@ -122,7 +122,7 @@
153,
153,
153,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -180,10 +180,10 @@
153,
153,
153,
255,
255,
255,
255,
1,
0,
0,
0,
142,
128,
6,
Expand Down
20 changes: 10 additions & 10 deletions types/spectest/generate/tests/ssvmsg.SSVMessageTest_ssvmessage_does_not_belong.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
0,
3,
1,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -64,10 +64,10 @@
0,
3,
1,
255,
255,
255,
255,
1,
0,
0,
0,
148,
143,
180,
Expand Down Expand Up @@ -122,7 +122,7 @@
153,
153,
153,
0,
1,
0,
0,
0,
Expand Down Expand Up @@ -180,10 +180,10 @@
153,
153,
153,
255,
255,
255,
255,
1,
0,
0,
0,
148,
143,
180,
Expand Down
8 changes: 4 additions & 4 deletions types/spectest/tests/ssvmsg/msg_id_belongs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ func MsgIDBelongs() *SSVMessageTest {
return &SSVMessageTest{
Name: "belongs",
MessageIDs: []types.MessageID{
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingValidatorPubKey[:], types.RoleCommittee),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingValidatorPubKey[:], types.RoleUnknown),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingValidatorPubKey[:], types.RoleCommittee),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingValidatorPubKey[:], types.RoleUnknown),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingValidatorPubKey[:], types.RoleAggregator),
},
BelongsToValidator: true,
}
Expand Down
8 changes: 4 additions & 4 deletions types/spectest/tests/ssvmsg/msg_id_doesnt_belong.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ func MsgIDDoesntBelongs() *SSVMessageTest {
return &SSVMessageTest{
Name: "does not belong",
MessageIDs: []types.MessageID{
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleCommittee),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleUnknown),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingWrongValidatorPubKey[:], types.RoleCommittee),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingWrongValidatorPubKey[:], types.RoleUnknown),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator),
types.NewMsgID(types.DomainType{0x99, 0x99, 0x99, 0x99}, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator),
},
BelongsToValidator: false,
}
Expand Down