generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 87
Prepare for SB10 #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+2,360
−298
Closed
Prepare for SB10 #569
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a064053
stop using serverRequire from storybook common, because it's about to…
ndelangen 958c7be
Update Node.js version to 20.16.0 in .nvmrc and workflows; reintroduc…
ndelangen fd3c654
Refactor typecheck workflow and update test mocks to use local server…
ndelangen b6bd5f6
Add error handling to getTestRunnerConfig function
ndelangen 2094e4b
Update tsup configuration to include Storybook dependencies and adjus…
ndelangen 7fd5891
Add semver dependency to package.json and update yarn.lock
ndelangen f4b51e6
Remove console error logging from getTestRunnerConfig function
ndelangen 49024ff
Enable treeshaking in tsup configuration for optimized builds
ndelangen de6531a
Update tsup configuration to exclude additional Storybook internal mo…
ndelangen d23885c
bundle in the whole core of storybook into the test-runner, since eve…
ndelangen 2a1e346
Update GitHub Actions workflow to set NODE_ENV and increase memory li…
ndelangen 8fcb31b
Refactor test commands in package.json and update GitHub Actions work…
ndelangen 4da85c2
babel everything
ndelangen 52a3bda
Merge pull request #570 from storybookjs/norbert/bundle-in-storybook
ndelangen 9afc71c
Update package.json to include multiple authors for better collaboration
ndelangen 6552af9
Update dependencies in package.json and yarn.lock, including the addi…
ndelangen d9d46ef
Enhance project structure by refactoring internal imports, adding new…
ndelangen 020e626
Remove TypeScript error suppression in transformCsf and update test c…
ndelangen 8609766
Update storybook-src dependency in package.json and yarn.lock to poin…
ndelangen f3d1819
Update Jest configuration to support ES2022 syntax by modifying the S…
ndelangen 9fa10a3
bump to new non-version-bundled
ndelangen 7e6c71c
fix tests
ndelangen db60cb3
Update storybook-src dependency in yarn.lock to point to the latest c…
ndelangen f437d4a
Update storybook version in package.json and yarn.lock to support 10.…
ndelangen 5cf9d6b
Merge branch 'next' into norbert/asyng-serverRequire-alt
ndelangen dbc63e2
Update storybook and storybook-src dependencies in package.json and y…
ndelangen 29f1ef4
Discard changes to tsconfig.json
ndelangen d0c3175
Discard changes to src/playwright/transformPlaywrightJson.ts
ndelangen 2c9779a
Enable TypeScript declaration file generation in tsup.config.ts, upda…
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v18 | ||
| v20.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { serverResolve } from 'storybook/internal/common'; | ||
| const { register } = require('esbuild-register/dist/node'); | ||
|
|
||
| register(); | ||
|
|
||
| export function serverRequire(path: string) { | ||
| const located = serverResolve(path); | ||
| if (!located) { | ||
| throw new Error(`Could not find ${path}`); | ||
| } | ||
|
|
||
| const result = require(located); | ||
|
|
||
| if (result.default) { | ||
| return result.default; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
ndelangen marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty annoying to keep up to date. Is the intention that each time esbuild releases a new version, this will be updated? Why not use
>= 0.18.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @IanVS
However the version range you mention promises to be compatible with "all future versions" of
esbuild.I think that's a promise that can't be kept.
And it locks libraries into a really bad spot.. if they release a new major version, they risk breaking the ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. Though I think you can use
0.18 - 0.25just to keep the list from becoming unmanageably long.