Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
d10r
commented
Mar 11, 2025
packages/ethereum-contracts/contracts/interfaces/superfluid/ISuperToken.sol
Show resolved
Hide resolved
d10r
changed the title
hellwolf
reviewed
Mar 14, 2025
hellwolf
reviewed
Mar 14, 2025
hellwolf
reviewed
Mar 14, 2025
hellwolf
approved these changes
Mar 18, 2025
XKCD Comic RelifLink: https://xkcd.com/2057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open questions:
is it a good idea to introduce OZ v5 for this? If so, we need to increase min solc version to 0.8.20.no, we don'tERC20Permit.sol?is it worth hashing the domain separator (as done by OZ)? Currently not done.I say no - the keccak opcode is 30 gas per word, so not much to squeeze out with optimization.shall the name for the signing domain be the token name? Currently it's just "SuperToken" for all.Made it the token name, as OZ does (and USDC too)TODO: add eip-5267 (doneeip712Domain()).SuperTokenIntegrationTest?