Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
d10r
changed the title
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
hellwolf
requested changes
Jun 18, 2025
| } | ||
|
|
||
| _handlePoolMemberNFT(memberAddr, newUnits); | ||
| // replicates GDAv1._isPool in order to eliminate unnecessary gas cost (less external calls) |
Contributor
There was a problem hiding this comment.
It's a low hanging fruit of not violating DRY: Extract the storage related function as a global "free" function so that reusing is strictly inlining same code in two different contracts (gda logic or the pool logic).
Contributor
There was a problem hiding this comment.
if you want faster 1.13 progress, removing this particular change is also okay for me. But I ask for no code quality degradation by not repeating code.
d10r
force-pushed
the
2025-06-incdec_poolunits
branch
from
2b12728 to
35e54ee
Compare
Contributor
|
I will propose a small improvement in the next commit. |
XKCD Comic RelifLink: https://xkcd.com/2077 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Additionally there's a small optimization:
GDA._isPool()is replicated inSuperfluidPool.sol.This shaves off a few thousand gas for
[update|increase|decrease]MemberUnit, because it removes an indirection through the GDA which adds 2 external calls (proxy and logic contract).The version is bumped to v1.13.0 because disabling the PoolMemberNFT update hooks is technically a breaking changes.
This PR doesn't yet remove all the PoolMemberNFT related code because for the deprecation its logic contract is updated one last time. After that, more of the related code can be removed.
v1.13.0 also contains the already merged #2057