[ETHEREUM-CONTRACTS] GDA storage layout refactoring

[hellwolf]

1. Move all token storage operations (grep -E 'AgreementStateSlot|createAgreement|terminateAgreement|updateAgreementData' packages/ethereum-contracts/contracts/agreements/gdav1/ packages/ethereum-contracts/test/foundry/agreements/gdav1/) to GDAv1StorageLayout.sol, which has GDAv1StorageLib, GDAv1StorageReader, GDAv1StorageWriter.
2. SuperfluidPool to use GDAv1StorageReader for isPool & isPoolMemberConnected.
3. Code cleanup of GeneralDistributionAgreementV1

[github-actions]

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

• CHANGELOG.md modified
• Double check before merge

[hellwolf]

All token storage operations are now in the GDAv1StorageLayout file:

nix-shell$ git grep -E 'AgreementStateSlot|createAgreement|terminateAgreement|updateAgreementData' packages/ethereum-contracts/contracts/agreements/gdav1/ packages/ethereum-contracts/test/foundry/agreements/gdav1/
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        return GDAv1StorageLib.decodeAccountData(token.getAgreementStateSlot
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        uint256 a = uint256(token.getAgreementStateSlot
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.updateAgreementStateSlot(
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.updateAgreementStateSlot(address(pool), GDAv1StorageLib.ACCOUNT_DATA_STATE_SLOT_ID, data);
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.updateAgreementStateSlot(
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.updateAgreementData(flowHash, GDAv1StorageLib.encodeFlowInfo(flowInfo));
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.createAgreement
packages/ethereum-contracts/contracts/agreements/gdav1/GDAv1StorageLayout.sol:        token.terminateAgreement(GDAv1StorageLib.getPoolMemberHash(poolMember, pool), 1);

[hellwolf]

@d10r, shouldn't _getPoolAdminNFTAddress also have been removed?

[d10r]

See comments. If you agree, I can do the changes.

[d10r]

@d10r, shouldn't _getPoolAdminNFTAddress also have been removed?

the admin NFT wasn't removed, only the member NFT.

[hellwolf]

Please also help to update CHANGELOG.md, then merge.

[github-actions]

XKCD Comic Relif

Link: https://xkcd.com/2086