Skip to content

Recovery diagnostics for repeat-while (testRecovery28) #3246

Open
Padmashree06 wants to merge 3 commits intoswiftlang:mainfrom
Padmashree06:recovery-test-28
Open

Recovery diagnostics for repeat-while (testRecovery28) #3246
Padmashree06 wants to merge 3 commits intoswiftlang:mainfrom
Padmashree06:recovery-test-28

Conversation

@Padmashree06
Copy link

@Padmashree06 Padmashree06 commented Jan 20, 2026

Issue : #1373
I’ve added DiagnosticSpecs for testRecovery28 following the pattern used in earlier recovery tests.

While doing this, I’m seeing test failures because the parser currently does not emit any diagnostics for this case, whereas the test expects three diagnostics and a fixed source (due to the presence of Fix-Its). This seems to stem from a difference between what the existing TODO comments describe and what the current parser behavior actually produces.

At this point, I’m unsure whether the test expectations should be updated to match the current parser behavior, or whether the parser is expected to be adjusted to emit the diagnostics described by the TODOs.

Could you please advise on the preferred approach here and whether I’m heading in the right direction before I continue further with the PR?

@ahoppen @rintaro

@Padmashree06
Copy link
Author

Hello @ahoppen ,

I’m currently unable to proceed further on this PR without your guidance and clarification.

When convenient, I would appreciate your direction on how to move forward.

Thank you very much for your time and support.

@ahoppen
Copy link
Member

ahoppen commented Jan 29, 2026

This issue is about making sure that we emit diagnostics that are the same (or similar) to the ones described in the TODO. Which diagnostics do we currently emit?

@Padmashree06
Copy link
Author

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants