Recovery diagnostics for repeat-while (testRecovery28) #3246
Open
Padmashree06 wants to merge 3 commits intoswiftlang:mainfrom
Open
Recovery diagnostics for repeat-while (testRecovery28) #3246Padmashree06 wants to merge 3 commits intoswiftlang:mainfrom
repeat-while (testRecovery28) #3246Padmashree06 wants to merge 3 commits intoswiftlang:mainfrom
Conversation
Author
|
Hello @ahoppen , I’m currently unable to proceed further on this PR without your guidance and clarification. When convenient, I would appreciate your direction on how to move forward. Thank you very much for your time and support. |
Member
|
This issue is about making sure that we emit diagnostics that are the same (or similar) to the ones described in the |
Author
|
Thank you for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : #1373
I’ve added
DiagnosticSpecs fortestRecovery28following the pattern used in earlier recovery tests.While doing this, I’m seeing test failures because the parser currently does not emit any diagnostics for this case, whereas the test expects three diagnostics and a fixed source (due to the presence of Fix-Its). This seems to stem from a difference between what the existing TODO comments describe and what the current parser behavior actually produces.
At this point, I’m unsure whether the test expectations should be updated to match the current parser behavior, or whether the parser is expected to be adjusted to emit the diagnostics described by the TODOs.
Could you please advise on the preferred approach here and whether I’m heading in the right direction before I continue further with the PR?
@ahoppen @rintaro