Skip to content

Recovery diagnostics for repeat-while (testRecovery28) #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Padmashree06 wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −1
Open

Recovery diagnostics for repeat-while (testRecovery28) #3246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d78f8aa
Add diagnostics to testRecovery28
Padmashree06 Jan 16, 2026
7538e4d
Align recovery test diagnostics with current parser behavior
Padmashree06 Jan 16, 2026
9933acb
Format code using swift-format
Padmashree06 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Tests/SwiftParserTest/translated/RecoveryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,12 +438,24 @@ final class RecoveryTests: ParserTestCase {
assertParse(
"""
repeat {
} while { true }()
} while1️⃣{ true }2️⃣()
""",
diagnostics: [
// TODO: Old parser expected error on line 2: missing condition in 'while' statement
// TODO: Old parser expected error on line 2: consecutive statements on a line must be separated by ';', Fix-It replacements: 10 - 10 = ';'
// TODO: Old parser expected warning on line 2: result of call to closure returning 'Bool' is unused
DiagnosticSpec(
locationMarker: "1️⃣",
message: "missing condition in 'while' statement"
),
DiagnosticSpec(
locationMarker: "2️⃣",
message: "consecutive statements on a line must be separated by ';'",
fixIts: ["seperate statements with ';"]
),
DiagnosticSpec(
message: "result of call to closure returning 'Bool' is unused"
),
]
)
}
Expand Down