Prevent NPE in shadow.test.karma/format-log#1245
Open
armincerf wants to merge 1 commit intothheller:masterfrom
Open
Prevent NPE in shadow.test.karma/format-log#1245armincerf wants to merge 1 commit intothheller:masterfrom
armincerf wants to merge 1 commit intothheller:masterfrom
Conversation
If a test assertion fails with an `:actual` value of nil, we get this error:
```
TypeError: Cannot read properties of null (reading 'hasOwnProperty')
at shadow$test$karma$format_log
```
rather than seeing details about the test failure, this can be quite misleading and a simple nil check will give clearer failure output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a test assertion fails with an
:actualvalue of nil, we get this error:rather than seeing details about the test failure, this can be quite misleading and a simple nil check will give clearer failure output