Skip to content

Prevent NPE in shadow.test.karma/format-log #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armincerf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent NPE in shadow.test.karma/format-log #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/main/shadow/test/karma.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,22 @@
(when-not (s/blank? testing-contexts-str)
(str "\"" testing-contexts-str "\"\n"))
(cond
(and (seq? expected)
(seq? actual))
(str
"expected: " (format-fn indentation expected) "\n"
" actual: " (format-fn indentation (second actual)) "\n"
(when-let [diff (format-diff indentation expected (second actual))]
(str " diff: " diff "\n")))
(.hasOwnProperty actual "stack")
(str "Exception: " (.-stack actual))
(nil? actual)
(str "expected: " (pr-str expected) "\n"
" actual: nil\n")

(and (seq? expected) (seq? actual))
(str "expected: " (format-fn indentation expected) "\n"
" actual: " (format-fn indentation (second actual)) "\n"
(when-let [diff (format-diff indentation expected (second actual))]
(str " diff: " diff "\n")))

(and (object? actual) (.hasOwnProperty actual "stack"))
(str "Exception: " (.-stack actual))

:else
(str expected " failed with " actual "\n"))
(str "expected: " (pr-str expected) "\n"
" actual: " (pr-str actual) "\n"))
(when message
(str " message: " (indent indentation message) "\n")))))

Expand Down